Skip to content

Commit be87801

Browse files
committed
Move test to e2e
Unfortunately currently the unit test job does not build VS Code so it ends up with a 500 in CI. Might change that in the future but for now move it to an e2e test.
1 parent 5b93f3f commit be87801

2 files changed

Lines changed: 9 additions & 12 deletions

File tree

test/e2e/appName.test.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import { version } from "../../src/node/constants"
2+
import { describe, test, expect } from "./baseFixture"
3+
4+
const appName = "testnäme"
5+
describe("--app-name", [`--app-name=${appName}`], {}, () => {
6+
test("should use app-name for the title", async ({ codeServerPage }) => {
7+
expect(await codeServerPage.page.title()).toContain(appName)
8+
})
9+
})

test/unit/node/routes/vscode.test.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,4 @@ describe("vscode", () => {
2727
})
2828
}).rejects.toThrow()
2929
})
30-
31-
it("should apply app-name to the VS Code product configuration", async () => {
32-
const appName = "testnäme"
33-
codeServer = await integration.setup(["--auth=none", `--app-name=${appName}`], "")
34-
35-
const resp = await codeServer.fetch("/vscode")
36-
const htmlContent = await resp.text()
37-
38-
expect(resp.status).toBe(200)
39-
expect(htmlContent).toContain(`"nameShort":"${appName}"`)
40-
expect(htmlContent).toContain(`"nameLong":"${appName}"`)
41-
})
4230
})

0 commit comments

Comments
 (0)