Skip to content

Commit 9998a5b

Browse files
committed
fix: use tests job result as gate for IT jobs in release cron
GitHub Actions does not reliably evaluate needs.<job>.outputs in if conditions on reusable workflow call jobs, causing them to be silently skipped. Switch to needs.tests.result == 'success' which is always evaluated correctly.
1 parent 354b582 commit 9998a5b

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/release-cron.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,42 +79,42 @@ jobs:
7979
integration-s3:
8080
name: Integration Tests - S3
8181
needs: [check, tests]
82-
if: needs.check.outputs.should_release == 'true'
82+
if: needs.tests.result == 'success'
8383
uses: ./.github/workflows/s3-integration.yml
8484
secrets: inherit
8585

8686
integration-gcs:
8787
name: Integration Tests - GCS
8888
needs: [check, tests]
89-
if: needs.check.outputs.should_release == 'true'
89+
if: needs.tests.result == 'success'
9090
uses: ./.github/workflows/gcs-integration.yml
9191
secrets: inherit
9292

9393
integration-azurebs:
9494
name: Integration Tests - Azure Blob Storage
9595
needs: [check, tests]
96-
if: needs.check.outputs.should_release == 'true'
96+
if: needs.tests.result == 'success'
9797
uses: ./.github/workflows/azurebs-integration.yml
9898
secrets: inherit
9999

100100
integration-alioss:
101101
name: Integration Tests - Alibaba OSS
102102
needs: [check, tests]
103-
if: needs.check.outputs.should_release == 'true'
103+
if: needs.tests.result == 'success'
104104
uses: ./.github/workflows/alioss-integration.yml
105105
secrets: inherit
106106

107107
integration-dav:
108108
name: Integration Tests - DAV
109109
needs: [check, tests]
110-
if: needs.check.outputs.should_release == 'true'
110+
if: needs.tests.result == 'success'
111111
uses: ./.github/workflows/dav-integration.yml
112112
secrets: inherit
113113

114114
build-and-release:
115115
name: Build and Release
116116
needs: [check, tests, integration-s3, integration-gcs, integration-azurebs, integration-alioss, integration-dav]
117-
if: needs.check.outputs.should_release == 'true'
117+
if: needs.tests.result == 'success'
118118
runs-on: ubuntu-latest
119119
steps:
120120
- name: Checkout Into Source Code

0 commit comments

Comments
 (0)