fix linting

Author: johha

app/actions/deployment_create.rb

@@ -95,11 +95,13 @@ def enhanced_deployment_create_error(e, app)
         org_error_msg = org_error_msg_1 + org_error_msg_2
         error_message = e.message
 
+        # rubocop:disable Style/ArrayIntersect -- e.message is a String, not an Array
         if space_quota_errors.any? { |substring| e.message.include?(substring) }
           error_message += space_error_msg
         elsif org_quota_errors.any? { |substring| e.message.include?(substring) }
           error_message += org_error_msg
         end
+        # rubocop:enable Style/ArrayIntersect
 
         error = DeploymentCreate::Error.new(error_message)
         error.set_backtrace(e.backtrace)

app/actions/domain_create.rb

@@ -42,11 +42,11 @@ def create(message:, shared_organizations: [])
     private
 
     def validation_error!(message, error)
-      error!("The domain name \"#{message.name}\" is already in use") if error.errors.on(:name)&.any? { |e| [:unique].include?(e) }
+      error!("The domain name \"#{message.name}\" is already in use") if error.errors.on(:name)&.intersect?([:unique])
 
-      error!("The \"#{message.name}\" domain is reserved and cannot be used for org-scoped domains.") if error.errors.on(:name)&.any? { |e| [:reserved].include?(e) }
+      error!("The \"#{message.name}\" domain is reserved and cannot be used for org-scoped domains.") if error.errors.on(:name)&.intersect?([:reserved])
 
-      if error.errors.on(:organization)&.any? { |e| [:total_private_domains_exceeded].include?(e) }
+      if error.errors.on(:organization)&.intersect?([:total_private_domains_exceeded])
         org = Organization.find(guid: message.organization_guid).name
         error!("The number of private domains exceeds the quota for organization \"#{org}\"")
       end

app/actions/role_create.rb

@@ -98,15 +98,14 @@ def create_organization_billing_manager(user, organization, role_type)
     end
 
     def space_validation_error!(type, error, user, space)
-      error!("User '#{user.presentation_name}' already has '#{type}' role in space '#{space.name}'.") if error.errors.on(%i[space_id user_id])&.any? { |e| [:unique].include?(e) }
+      error!("User '#{user.presentation_name}' already has '#{type}' role in space '#{space.name}'.") if error.errors.on(%i[space_id user_id])&.intersect?([:unique])
 
       error!(error.message)
     end
 
     def organization_validation_error!(type, error, user, organization)
-      error!("User '#{user.presentation_name}' already has '#{type}' role in organization '#{organization.name}'.") if error.errors.on(%i[organization_id user_id])&.any? do |e|
-                                                                                                                         [:unique].include?(e)
-                                                                                                                       end
+      error!("User '#{user.presentation_name}' already has '#{type}' role in organization '#{organization.name}'.") if error.errors.on(%i[organization_id
+                                                                                                                                          user_id])&.intersect?([:unique])
 
       error!(error.message)
     end

app/actions/user_create.rb

@@ -26,11 +26,9 @@ def create(message:)
     private
 
     def validation_error!(message, error)
-      error!("User with guid '#{message.guid}' already exists.") if message.guid && error.errors.on(:guid)&.any? { |e| [:unique].include?(e) }
+      error!("User with guid '#{message.guid}' already exists.") if message.guid && error.errors.on(:guid)&.intersect?([:unique])
 
-      if !message.guid && error.errors.on(:guid)&.any? { |e| [:unique].include?(e) }
-        error!("User with username '#{message.username}' and origin '#{message.origin}' already exists.")
-      end
+      error!("User with username '#{message.username}' and origin '#{message.origin}' already exists.") if !message.guid && error.errors.on(:guid)&.intersect?([:unique])
 
       error!(error.message)
     end

app/decorators/include_binding_app_decorator.rb

@@ -2,7 +2,7 @@ module VCAP::CloudController
   class IncludeBindingAppDecorator
     class << self
       def match?(include)
-        include&.any? { |i| %w[app].include?(i) }
+        include&.intersect?(%w[app])
       end
 
       def decorate(hash, bindings)

app/decorators/include_binding_service_instance_decorator.rb

@@ -4,7 +4,7 @@ module VCAP::CloudController
   class IncludeBindingServiceInstanceDecorator
     class << self
       def match?(include)
-        include&.any? { |i| %w[service_instance].include?(i) }
+        include&.intersect?(%w[service_instance])
       end
 
       def decorate(hash, bindings)

app/decorators/include_organization_decorator.rb

@@ -2,7 +2,7 @@ module VCAP::CloudController
   class IncludeOrganizationDecorator
     class << self
       def match?(include)
-        include&.any? { |i| %w[org space.organization].include?(i) }
+        include&.intersect?(%w[org space.organization])
       end
 
       def decorate(hash, resources)

app/decorators/include_route_domain_decorator.rb

@@ -2,7 +2,7 @@ module VCAP::CloudController
   class IncludeRouteDomainDecorator
     class << self
       def match?(include)
-        include&.any? { |i| %w[domain].include?(i) }
+        include&.intersect?(%w[domain])
       end
 
       def decorate(hash, routes)

app/decorators/include_space_decorator.rb

@@ -2,7 +2,7 @@ module VCAP::CloudController
   class IncludeSpaceDecorator
     class << self
       def match?(include)
-        include&.any? { |i| %w[space space.organization].include?(i) }
+        include&.intersect?(%w[space space.organization])
       end
 
       def decorate(hash, resources)

app/decorators/include_space_organization_decorator.rb

@@ -2,7 +2,7 @@ module VCAP::CloudController
   class IncludeSpaceOrganizationDecorator
     class << self
       def match?(include)
-        include&.any? { |i| %w[org organization].include?(i) }
+        include&.intersect?(%w[org organization])
       end
 
       def decorate(hash, spaces)