Fix: reject --source-org with --source-app when --source-space is missing

When a user specifies --source-org with --source-app but omits --source-space,
validateSourceFlags() previously passed (treating --source-app as the sole
primary flag), and resolveSource() silently ignored --source-org, resolving
the app in the currently targeted space.

Add a pre-check in validateSourceFlags() that returns RequiredFlagsError
(--source-org and --source-space must be used together) whenever --source-org
is combined with --source-app but --source-space is absent.

Author: rkoster

command/v7/add_route_policy_command_test.go

@@ -80,6 +80,22 @@ var _ = Describe("add-route-policy Command", func() {
 		})
 	})
 
+	When("--source-org is used with --source-app but without --source-space", func() {
+		BeforeEach(func() {
+			cmd.RoutePolicySourceFlags = RoutePolicySourceFlags{
+				SourceApp: "my-app",
+				SourceOrg: "my-org",
+			}
+		})
+
+		It("returns a RequiredFlagsError for --source-space", func() {
+			Expect(executeErr).To(MatchError(translatableerror.RequiredFlagsError{
+				Arg1: "--source-org",
+				Arg2: "--source-space",
+			}))
+		})
+	})
+
 	When("checking the target fails", func() {
 		BeforeEach(func() {
 			fakeSharedActor.CheckTargetReturns(actionerror.NotLoggedInError{BinaryName: "faceman"})

command/v7/remove_route_policy_command_test.go

@@ -81,6 +81,22 @@ var _ = Describe("remove-route-policy Command", func() {
 		})
 	})
 
+	When("--source-org is used with --source-app but without --source-space", func() {
+		BeforeEach(func() {
+			cmd.RoutePolicySourceFlags = RoutePolicySourceFlags{
+				SourceApp: "my-app",
+				SourceOrg: "my-org",
+			}
+		})
+
+		It("returns a RequiredFlagsError for --source-space", func() {
+			Expect(executeErr).To(MatchError(translatableerror.RequiredFlagsError{
+				Arg1: "--source-org",
+				Arg2: "--source-space",
+			}))
+		})
+	})
+
 	When("checking the target fails", func() {
 		BeforeEach(func() {
 			fakeSharedActor.CheckTargetReturns(actionerror.NotLoggedInError{BinaryName: "faceman"})

command/v7/route_policy_source_flags.go

@@ -39,6 +39,14 @@ func (f RoutePolicySourceFlags) validateSourceFlags() error {
 		sourceFlags = append(sourceFlags, "--source-any")
 	}
 
+	// --source-org requires --source-space when used with --source-app
+	if f.SourceOrg != "" && f.SourceApp != "" && f.SourceSpace == "" {
+		return translatableerror.RequiredFlagsError{
+			Arg1: "--source-org",
+			Arg2: "--source-space",
+		}
+	}
+
 	if len(sourceFlags) == 0 {
 		return translatableerror.RequiredArgumentError{
 			ArgumentName: "one of: --source-app, --source-space, --source-org, --source-any, or --source",