Duplicated depends marked with <!nocheck>

[swt2c]

After the <!nocheck> change, cabal-debian seems to be adding duplicate depends, where one duplicate is marked with <!nocheck> and one is not. An example package where this happens is hslua-module-system. I believe this happens because this package has a common-options section which gets included in both a library and a test-suite. Ultimately, there is a depend that's in both a library and a test suite. It seems this was deduplicated before (I think) but now is not? It seems the <!nocheck> one should just not be there.

[clinty]

If I recall correctly, the deduplication broke due to a Cabal API change years ago, and we've never gotten around to fixing it.

I've been meaning to try to shoehorn something like a better version of this in at some point:

data HD =
    DevDocProf Dependency
  | Dev Dependency
  | DevNocheck Dependency
  deriving (Show, Eq, Ord)

instance Semigroup HD
    where
        DevDocProf a <> DevDocProf b = DevDocProf (intersectD a b)
        DevDocProf a <> Dev b = DevDocProf (intersectD a b)
        DevDocProf a <> DevNocheck b = DevDocProf (intersectD a b)
        Dev a <> DevDocProf b = DevDocProf (intersectD a b)
        Dev a <> Dev b = Dev (intersectD a b)
        Dev a <> DevNocheck b = Dev (intersectD a b)
        DevNocheck a <> DevDocProf b = DevDocProf (intersectD a b)
        DevNocheck a <> Dev b = Dev (intersectD a b)
        DevNocheck a <> DevNocheck b = DevNocheck (intersectD a b)

dep :: HD -> Dependency
dep (DevDocProf d) = d
dep (Dev d) = d
dep (DevNocheck d) = d

intersectD :: Dependency -> Dependency -> Dependency
intersectD (Dependency aname arange alnnes) (Dependency bname brange blnnes)
    | aname == bname && alnnes == blnnes = Dependency aname (intersectVersionRanges arange brange) alnnes
    | otherwise = error "too much inequality in dependencies"

[swt2c]

Yeah you are probably right, I probably just got used to manually filtering out the dupes, but now I noticed because they now are prefixed with nocheck :)