From 5cd704a697ad8663bed77f0ab2503224ca1d9787 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 21 Feb 2026 14:20:33 +0000 Subject: [PATCH] Fix markdownlint errors, actionlint CI job, and SC2044 warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit README.md: fix blank lines around heading, remove double blank lines, remove trailing space, add final newline (MD022, MD012, MD009, MD047). actionlint: replace raven-actions/actionlint@v2 wrapper (linted 0 files) with direct install from rhysd/actionlint. syntax-check: replace fragile `for f in $(find ...)` with `while read -d '' ... < <(find -print0)` to fix SC2044 warning reported by actionlint's integrated shellcheck. All 5 CI linters verified locally: markdownlint, actionlint, shellcheck, shfmt, codespell — 0 errors. https://claude.ai/code/session_01GUjwhhcF9R4o72g3wx98ey --- .github/workflows/lint.yml | 9 ++++++--- README.md | 7 +++---- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 1077661..adbf07b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -26,12 +26,12 @@ jobs: - name: Check bash syntax run: | errors=0 - for f in $(find . -name '*.sh' -type f); do + while IFS= read -r -d '' f; do if ! bash -n "$f"; then echo "Syntax error in $f" errors=$((errors + 1)) fi - done + done < <(find . -name '*.sh' -type f -print0) if [ "$errors" -gt 0 ]; then echo "$errors file(s) with syntax errors" exit 1 @@ -67,7 +67,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: raven-actions/actionlint@v2 + - name: Install actionlint + run: bash <(curl -s https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) + - name: Run actionlint + run: ./actionlint markdownlint: name: Markdown Lint diff --git a/README.md b/README.md index 8ba623f..768d7c6 100644 --- a/README.md +++ b/README.md @@ -1,12 +1,11 @@ # ProxRescue -Proxmox Products Installer in Rescue Mode for Hetzner +Proxmox Products Installer in Rescue Mode for Hetzner Description This script is designed to install Proxmox products (Proxmox Virtual Environment, Proxmox Backup Server, Proxmox Mail Gateway) in rescue mode on Hetzner servers. It allows you to select the product to install, configure VNC connection settings, and use UEFI if needed. Additionally, the script can launch the installed Proxmox system, allowing you to connect via VNC or noVNC. - Requirements Before running the script, ensure that your system has the following packages installed: @@ -122,7 +121,7 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +SOFTWARE. Communities and Support @@ -130,4 +129,4 @@ Communities and Support GitHub: https://github.com/Proxmoxinfo/ProxMoxRescueHelper Website: proxmox.info -This script is designed for installing Proxmox products in rescue mode on Hetzner servers. \ No newline at end of file +This script is designed for installing Proxmox products in rescue mode on Hetzner servers.