Skip to content

FR: Feedback #94

Description

@matyaskopp

I will extend the feedback soon

Nice work, thanks for aligning facsimiles with text!

hyphenated words

  • repeated hyphenated words

https://github.com/cppmai1103/PressMint/blob/791b7b4ce56b927d811ea369b92e8d8e85841242/Samples/PressMint-FR/1920/PressMint-FR_1920-01-01-LeTemps-BnF-0243877.xml#L6085-L6086

<lb facs="#PressMint-FR_1920-01-01-LeTemps-BnF-0243877.page1.tl000041"/>discussion publique. D'ailleurs, qu'il se .produ�as quelques
<lb facs="#PressMint-FR_1920-01-01-LeTemps-BnF-0243877.page1.tl000042"/>quelques jours plus t�t ou plus tard,' ce d�bat doit

You can see multiple occurrences in the paragraph (highlighted only the one above):
Image
Image

broken encoding

  • accented characters are broken

https://github.com/cppmai1103/PressMint/blob/58024c7ba634b5a94c46d575353739dc620c0cd8/Samples/PressMint-FR/1920/PressMint-FR_1920-01-01-LeTemps-BnF-0243877.xml#L6076

<lb facs="#PressMint-FR_1920-01-01-LeTemps-BnF-0243877.page1.tl000032"/>LE PROBL�ME DE CONSTANTINOPLE

the byte sequence is C3 AF C2 BF C2 BD but it should be C3 88 to print È in utf-8

this error needs to be fixed in the pipeline, because all characters are broken in the same way

Nest page content in pageBody

  • nesting zones

https://github.com/cppmai1103/PressMint/blob/791b7b4ce56b927d811ea369b92e8d8e85841242/Samples/PressMint-FR/1920/PressMint-FR_1920-01-01-LeTemps-BnF-0243877.xml#L94

<zone xml:id="PressMint-FR_1920-01-01-LeTemps-BnF-0243877.page1.body" type="pageBody" ulx="148" uly="1189" lrx="5712" lry="7714"/>

should be:

<zone xml:id="PressMint-FR_1920-01-01-LeTemps-BnF-0243877.page1.body" type="pageBody" ulx="148" uly="1189" lrx="5712" lry="7714">
  <!-- column/block/line zones nested in pageBody -->
</zone>

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions