ES-PV: Feedback

[matyaskopp]

This comment is based on a single page of a magazine

I have some of the suggestions already mentioned within the pull request, but a separate issue might be more suitable...
A preview of downstream formats is available here: https://github.com/clarin-eric/PressMint/tree/preview-pr-28--ES-PV/Samples/PressMint-ES-PV

id should be the same as filename without extension

• /tei:*/@xml:id value

https://github.com/x2gg/PressMint/blob/3cbf8d99ec8937ace27e2ad3392ba58a9c6d9163/Samples/PressMint-ES-PV/PressMint-ES-PV.xml#L2

<teiCorpus xmlns="http://www.tei-c.org/ns/1.0" xml:id="PressMint-EU-ES" xml:lang="eu">

should be

<teiCorpus xmlns="http://www.tei-c.org/ns/1.0" xml:id="PressMint-ES-PV" xml:lang="eu">

and similarly for the annotated version:
https://github.com/x2gg/PressMint/blob/3cbf8d99ec8937ace27e2ad3392ba58a9c6d9163/Samples/PressMint-ES-PV/PressMint-ES-PV.ana.xml#L2

(validation needs to be fixed #70)

wrong volume number

• volume number

https://github.com/x2gg/PressMint/blob/3cbf8d99ec8937ace27e2ad3392ba58a9c6d9163/Samples/PressMint-ES-PV/1911/PressMint-ES-PV_1911-06-15-EUSKAL-ESNALEA.xml#L31

               <biblScope unit="volume">11</biblScope>

based on https://w390w.gipuzkoa.net/WAS/CORP/DKPAtzokoPrentsaWEB/argitalpen/176957
the volume number should be 4 for this particular file

issue number

I took a look at other issues, and it seems that there are some joined issues: https://w390w.gipuzkoa.net/WAS/CORP/DKPAtzokoPrentsaWEB/argitalpen/176957/data/-1852894800000
It is just an observation; you should take it into account when you encode this.

facsimile url

• graphic/@url does not point to an image

https://github.com/x2gg/PressMint/blob/3cbf8d99ec8937ace27e2ad3392ba58a9c6d9163/Samples/PressMint-ES-PV/1911/PressMint-ES-PV_1911-06-15-EUSKAL-ESNALEA.xml#L43-L45

      <surface xml:id="PressMint-ES-PV_1911-06-15-EUSKAL-ESNALEA.page1">
         <graphic url="https://w390w.gipuzkoa.net/WAS/CORP/DKPAtzokoPrentsaWEB/argitalpen/176957/data/-1847620800000"/>
      </surface>

Would it be possible to provide a URL that points to an image?

• this URL uses the webapp https://w390w.gipuzkoa.net/WAS/CORP/DKPAtzokoPrentsaWEB/filenet/irudia/%7BEE13FA87-80E8-4A35-BC9A-C7B015198FFC%7D
• this also works: https://w390w.gipuzkoa.net/WAS/CORP/DKPAtzokoPrentsaWEB/filenet/irudia/%7BEE13FA87-80E8-4A35-BC9A-C7B015198FFC%7D.jpg

incomplete issue

• marking gaps in data

Is this a full version of the data? https://w390w.gipuzkoa.net/WAS/CORP/DKPAtzokoPrentsaWEB/argitalpen/176957/data/-1847624400000

• first page is 11 and then follows page 146

There is a possibility of inserting gap (https://clarin-eric.github.io/PressMint/#sec-gaps) when some content is missing

invalid tokenization

• ¿ is a part of a token when basque using Spanish question marks

https://github.com/x2gg/PressMint/blob/3cbf8d99ec8937ace27e2ad3392ba58a9c6d9163/Samples/PressMint-ES-PV/1911/PressMint-ES-PV_1911-06-15-EUSKAL-ESNALEA.ana.xml#L197

               <w msd="UPosTag=NOUN|Animacy=Inan|Case=Erg|Definite=Def|Number=Sing" lemma="¿irundar">
                  ¿Irundarrak</w>

This can be easily fixed with a rule-based patch

number of paragraphs

• annotated and non-annotated versions should contain the same number of paragraphs

no named entities

• Just for the record, I guess you will add them later