Bulk rename error

[CoolColJ]

When I pasted a bulk rename from PSpad the numbering is off.

I append a number and CCJ_ in front of each filename.
The number should be off by 1 each line, but at patch 80 it skipped one line
Patch 84 skipped the rename altogether
But it goes back to normal at patch 85

[art507]

Hello!
I'm using Knob Kraft version 2.9.0 for the Prophet 5 Rev 4 module. I can't figure out how to change the user preset names. I've tried several methods, from simply sending the renamed patches from the Library to the synth, to saving them to the Prophet afterward using Rec+ instead of Patch. But the names won't change…

[christofmuc]

@CoolColJ Thanks for reporting! This looks like a very peculiar bug, i will have a look and try to recreate it. Is there maybe a duplicate patch in the bank? That could be a problem for the rename implementation.

[CoolColJ]

I don't think there is a duplicate patch but I'm not sure.

When I delete the offending patch (which it hides) and try and reimport, and do a bulk rename, the same problem occurs.

Ordering by patch number, this particular patch doesn't show up in the number order.
When I click on this patch 84, it doesn't even highlight in the main view like the other patches.
It shows the patch number as 00-00, instead of 00-84

Importing other banks in the same synth, with bulk rename worked ok

[christofmuc]

That does sound a bit like this specific patch is broken in a way - I can see it was imported as edit buffer, not program buffer, maybe the conversion from edit buffer to program buffer, which is required to put an edit buffer into a bank, is broken somehow. Can you share the bank, via email in case you don't want to attach it here publicly?

[CoolColJ]

Ok, will email you a zip file of the following - the current Trigon-6 Bank1 in KnobKraft is sysex whole and individual zipped format.
Older sysex of bank1, and current sysex of bank1 in case something has changed since then.

[christofmuc]

I tested a lot, and cannot reproduce the problem, it works for me.

But I encountered a gotcha we might be missing - the Bulk rename operation always works on the main grid in the center, not in the bank window. You pasted a view of the bank, but what got renamed is the list/import in the center grid.

How I would rename a bank: Drag the bank into the user lists section, this creates a list from the bank. Then click that list, that loads the 100 patches into the main view. Then do Edit... Bulk rename. For me, this correctly renames the 100 patches in the list. In the current KnobKraft, this also renames the patches in all other places, because a patch can only have one name (there is a feature request to change that, but for now that is what we got).

If you refresh the bank, you should see a correct renamed list.

At least that is my theory what is going on from what I have tested so far. Can you try?

[CoolColJ]

I did the bulk rename from the import pop up, not the bank view

I will try the user lists section rename
But the last time I reimported the bank, all the names were lost and reverted to "basic program"
So it does not seem to be worth the effort, unless there is a way to change this behaviour?

[christofmuc]

Ah, I missed that code path because I can not test it without the synth itself! So you're renaming immediately when importing the patches from the synth? The import from files dialog does not offer bulk rename, which is why I was assuming you were using the Edit.. Bulk rename function.

I will test more but need to think of a way to do this without the real synth.

[CoolColJ]

yes I was renaming immediately upon import.

[christofmuc]

I found and reproduced the cause of the names reverting to "Basic Program" on reimport. The Trigon-6 adaptation did not identify "Basic Program" as a default name, so KnobKraft treated it as a normal incoming name and overwrote the custom name you had assigned in the librarian.

This is addressed in #566 and will be fixed in version 2.10. Reimporting the same sound with the default name will then preserve your custom name.

I have not yet reproduced the original skipped/misaligned rows during bulk rename, so I am leaving this issue open. Once 2.10 is available, could you please verify that your custom names survive reimport and check whether the bulk rename numbering problem still occurs?

If the numbering problem remains, please share the steps from import through pasting and confirming the names, along with the affected bank (or resend it by email if you prefer). Please also mention whether those patches were already in your library before the import, and include a screenshot showing the expected and actual names around the affected slots. That should help distinguish the remaining problem from the name-loss defect.