Skip to content

Proposal: Separate internal and public functions into different files to help with Diamonds #22

Description

@RogerPodacter

I'm using the Diamond standard and it would be useful for me to be able to _mint() from multiple facets.

However, multiple facets cannot inherit from ERC721AUpgradeable because ERC721AUpgradeable has public functions and multiple facets cannot define the same public function.

I propose adding a ERC721AInternal contract that Diamond-ers can inherit from in multiple places. This would not affect anyone else as they could continue inheriting from ERC721AUpgradeable (basically what I'm proposing is a copy-paste).

SolidState takes this approach for their ERC721, so it has been done!

Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions