chore: comply more to default TS config (#3743)

Author: targos

src/component/1d-2d/FieldEdition.tsx

@@ -38,14 +38,6 @@ function stopPropagation(e: any) {
   e.stopPropagation();
 }
 
-function keyDownCheck(event: React.KeyboardEvent<HTMLInputElement>) {
-  if (event.key === 'Enter') {
-    return true;
-  } else if (event.key === 'Escape') {
-    return false;
-  }
-}
-
 export function FieldEdition(props: FieldEditionsProps) {
   const { value, inputType = 'text', onChange, children, PopoverProps } = props;
   const [isOpen, setIsOpen] = useState(false);
@@ -84,7 +76,7 @@ function Field(props: FieldProps) {
   });
 
   function handleKeyDown(event: React.KeyboardEvent<HTMLInputElement>) {
-    if (keyDownCheck(event)) {
+    if (event.key === 'Enter') {
       void handleSubmit(onChange)();
     }
   }

src/component/1d/peaks/PeakEditionManager.tsx

@@ -167,6 +167,8 @@ function PeakEditionField({ value, onClose }: PeakFieldProps) {
     } else if (event.key === 'Escape') {
       onClose();
       return false;
+    } else {
+      return false;
     }
   }
   function handleOnSubmit({ value: newValue }: FieldValues) {

src/component/2d/SignalDeltaLine.tsx

@@ -1,4 +1,5 @@
 import styled from '@emotion/styled';
+import { assert } from 'react-science/ui';
 
 import { useChartData } from '../context/ChartContext.js';
 
@@ -16,7 +17,8 @@ interface SignalDeltaLineProps {
   show: boolean;
 }
 
-function SignalDeltaLine({ delta, axis, show }: SignalDeltaLineProps) {
+function SignalDeltaLine(props: SignalDeltaLineProps) {
+  const { delta, axis, show } = props;
   const { xDomain, yDomain } = useChartData();
   const scaleX = useScale2DX();
   const scaleY = useScale2DY();
@@ -33,9 +35,8 @@ function SignalDeltaLine({ delta, axis, show }: SignalDeltaLineProps) {
         y2={scaleY(yDomain[1])}
       />
     );
-  }
-
-  if (axis === 'Y') {
+  } else {
+    assert(axis === 'Y');
     return (
       <SignalLine
         key={`signalLine_${delta}_Y`}

src/component/context/SortSpectraContext.tsx

@@ -163,11 +163,11 @@ interface SortItem {
   sortValue: string | number | boolean | null | undefined;
 }
 
-function sortArray(data: SortItem[], sortDirection?: SortDirection) {
+function sortArray(data: SortItem[], sortDirection?: SortDirection): void {
   const direction = sortDirection === 'asc' ? 1 : -1;
 
   if (!sortDirection) {
-    return data;
+    return;
   }
 
   data.sort((a, b) => {

src/component/elements/NextPrev.tsx

@@ -83,52 +83,28 @@ const transition = 0.45;
 
 interface NextPrevProps {
   children: ReactElement | ReactElement[];
-  loop?: boolean;
   index: number;
   onChange: (element: number) => void;
   style?: { arrowContainer?: CSSProperties };
 }
 
 export function NextPrev(props: NextPrevProps) {
-  const {
-    children,
-    loop = false,
-    index = 0,
-    onChange = () => null,
-    style = {},
-  } = props;
+  const { children, index = 0, onChange = () => null, style = {} } = props;
   const [ref, { width } = { width: 0 }] = useResizeObserver();
   const slidersCount = Children.count(children);
   const lastIndex = slidersCount > 0 ? slidersCount - 1 : 0;
   const activeIndex = Math.min(index, lastIndex);
 
   function nextHandler() {
-    if (index === lastIndex) {
-      onChange(index);
-
-      if (loop) {
-        return 0;
-      } else {
-        return index;
-      }
+    if (index < lastIndex) {
+      onChange(index + 1);
     }
-
-    const nextIndex = index + 1;
-    onChange(nextIndex);
   }
 
   function prevHandler() {
-    if (index === 0) {
-      onChange(index);
-      if (loop) {
-        return 0;
-      } else {
-        return index;
-      }
+    if (index > 0) {
+      onChange(index - 1);
     }
-    const prevIndex = index - 1;
-
-    onChange(prevIndex);
   }
 
   if (!width && slidersCount === 0) return null;

src/component/elements/export/ExportManager.tsx

@@ -95,9 +95,12 @@ export function ExportManagerController(props: ExportManagerControllerProps) {
     triggerExport(null);
   }
 
-  function handleExport(targetElement: HTMLElement, options: ExportSettings) {
+  function handleExport(
+    targetElement: HTMLElement,
+    options: ExportSettings,
+  ): void {
     if (!exportOptions) {
-      return null;
+      return;
     }
 
     if (!hasDataToExport) {
@@ -106,7 +109,7 @@ export function ExportManagerController(props: ExportManagerControllerProps) {
         intent: 'danger',
         message: 'No spectra available for export',
       });
-      return null;
+      return;
     }
 
     const { format, destination = 'file' } = exportOptions;

src/component/elements/pdnd.cts

@@ -2,7 +2,9 @@
 // Given how `@atlaskit/pragmatic-drag-and-drop` publishes ESM in a non-native way,
 // we have to trick TS into using the CJS build so that our build is compatible
 // with native ESM.
-// We cannot use `verbatimModuleSyntax` ts config option with this pattern.
+// This file is not compatible with the `verbatimModuleSyntax` TS option.
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+// @ts-nocheck
 export {
   draggable,
   dropTargetForElements,

src/component/hooks/useSaveSettings.tsx

@@ -2,7 +2,6 @@ import { Dialog, DialogBody, DialogFooter } from '@blueprintjs/core';
 import styled from '@emotion/styled';
 import { yupResolver } from '@hookform/resolvers/yup';
 import type { Workspace } from '@zakodium/nmrium-core';
-import type { KeyboardEvent } from 'react';
 import { useRef } from 'react';
 import { useForm } from 'react-hook-form';
 import { useOnOff } from 'react-science/ui';
@@ -19,14 +18,6 @@ const schema = Yup.object().shape({
   workspaceName: Yup.string().required(),
 });
 
-function keyDownCheck(event: KeyboardEvent<HTMLInputElement>) {
-  if (event.key === 'Enter') {
-    return true;
-  } else if (event.key === 'Escape') {
-    return false;
-  }
-}
-
 function WorkspaceAddForm(props: any) {
   const { className, message, control, onEnter } = props;
 
@@ -44,7 +35,7 @@ function WorkspaceAddForm(props: any) {
         autoFocus
         size="large"
         onKeyDown={(event) => {
-          if (keyDownCheck(event)) {
+          if (event.key === 'Enter') {
             onEnter();
           }
         }}

src/component/modal/metaImportation/MetaImportationModal.tsx

@@ -240,6 +240,7 @@ function InnerMetaImportationModal({
     } else if (record) {
       return rowColors.match;
     }
+    return undefined;
   }
 
   function handleImport() {

src/component/modal/setting/GeneralSettings.tsx

@@ -351,7 +351,7 @@ function WorkSpaceActionsButtons(props: any) {
     reset(workSpaceDisplayPreferences);
   }
 
-  function handlePastWorkspace(text: string | undefined) {
+  function handlePasteWorkspace(text: string | undefined) {
     if (!text) return;
 
     try {
@@ -365,7 +365,7 @@ function WorkSpaceActionsButtons(props: any) {
   }
 
   function handlePastWorkspaceAction() {
-    void readText().then(handlePastWorkspace);
+    void readText().then(handlePasteWorkspace);
   }
 
   function handleCopyWorkspace() {
@@ -428,7 +428,7 @@ function WorkSpaceActionsButtons(props: any) {
       <ClipboardFallbackModal
         mode={shouldFallback}
         onDismiss={cleanShouldFallback}
-        onReadText={handlePastWorkspace}
+        onReadText={handlePasteWorkspace}
         text={text}
         label="Workspace"
       />
@@ -453,7 +453,8 @@ function DialogActionButtons(props: BasseGeneralModalProps) {
 
   function applyPreferencesHandler() {
     if (!isValid) {
-      return handleSubmit(submitHandler)();
+      void handleSubmit(submitHandler)();
+      return;
     }
 
     dispatch({