feat: improve min level determination contours #10597
jobo322nodejs.yml
on: pull_request
nodejs
/
prepare
20s
knip
50s
stylelint
50s
nodejs
/
lint-eslint
1m 45s
nodejs
/
lint-prettier
41s
nodejs
/
lint-check-types
1m 0s
nodejs
/
test-package
52s
Matrix: nodejs / test
Annotations
7 errors and 10 warnings
|
nodejs / test (24)
Process completed with exit code 1.
|
|
src/data/data2d/Spectrum2D/findBestMinContour/estimateNoiseLevel.test.ts > rejects invalid sample sizes and zero MAD:
src/data/data2d/Spectrum2D/findBestMinContour/estimateNoiseLevel.test.ts#L33
AssertionError: expected [Function] to throw an error
- Expected:
null
+ Received:
undefined
❯ src/data/data2d/Spectrum2D/findBestMinContour/estimateNoiseLevel.test.ts:33:62
|
|
src/data/data2d/Spectrum2D/findBestMinContour/estimateNoiseLevel.test.ts > ignores non-finite sampled values:
src/data/data2d/Spectrum2D/findBestMinContour/estimateNoiseLevel.ts#L48
Error: unable to estimate a positive noise level
❯ estimateNoiseLevel src/data/data2d/Spectrum2D/findBestMinContour/estimateNoiseLevel.ts:48:11
❯ src/data/data2d/Spectrum2D/findBestMinContour/estimateNoiseLevel.test.ts:26:10
|
|
nodejs / test-package
The process '/opt/hostedtoolcache/node/24.19.0/x64/bin/npm' failed with exit code 1
|
|
nodejs / test-package:
src/component/workspaces/workspaceDefaultProperties.ts#L74
Type '{ baselineCorrection: false; exclusionZones: false; exportAs: false; fft: false; import: false; integral: false; multipleSpectraAnalysis: false; phaseCorrection: false; rangePicking: false; ... 18 more ...; phaseCorrectionTwoDimensions: false; }' does not satisfy the expected type 'Required<Partial<NMRiumToolbarPreferences> | undefined>'.
|
|
nodejs / lint-check-types
Process completed with exit code 2.
|
|
nodejs / lint-check-types:
src/component/workspaces/workspaceDefaultProperties.ts#L74
Type '{ baselineCorrection: false; exclusionZones: false; exportAs: false; fft: false; import: false; integral: false; multipleSpectraAnalysis: false; phaseCorrection: false; rangePicking: false; ... 18 more ...; phaseCorrectionTwoDimensions: false; }' does not satisfy the expected type 'Required<Partial<NMRiumToolbarPreferences> | undefined>'.
|
|
nodejs / lint-eslint:
src/component/2d/zones/Zone.tsx#L41
Avoid adjusting state when a prop changes. Instead, adjust "reduceOpacity" directly during render when "props" changes, or refactor your state to avoid this need entirely
|
|
nodejs / lint-eslint:
src/component/2d/zones/Signal.tsx#L40
Avoid adjusting state when a prop changes. Instead, adjust "isHighlighted" directly during render when "props" changes, or refactor your state to avoid this need entirely
|
|
nodejs / lint-eslint:
src/component/2d/zones/Signal.tsx#L38
Avoid adjusting state when a prop changes. Instead, adjust "isHighlighted" directly during render when "props" changes, or refactor your state to avoid this need entirely
|
|
nodejs / lint-eslint:
src/component/2d/ft/Contours.tsx#L90
Unexpected 'todo' comment: 'TODO: make sure preferences are not a...'
|
|
nodejs / lint-eslint:
src/component/1d/ranges/FloatingRanges.tsx#L314
Avoid storing derived state. Instead, compute "bounding" directly during render
|
|
nodejs / lint-eslint:
src/component/1d/multiplicityTree/generateTreeNodes.ts#L28
Unexpected 'todo' comment: 'TODO: make sure spectrumData is not a...'
|
|
nodejs / lint-eslint:
src/component/1d/multiplicityTree/MultiplicityTree.tsx#L246
Do not use Array index in keys
|
|
nodejs / lint-eslint:
src/component/1d/inset/DraggableInset.tsx#L72
Avoid storing derived state. Instead, compute "bounding" directly during render
|
|
nodejs / lint-eslint:
src/component/1d/FloatPublicationString.tsx#L257
Avoid adjusting state when a prop changes. Instead, adjust "bounding" directly during render when "externalBoundingPercent" changes, or refactor your state to avoid this need entirely
|
|
nodejs / lint-eslint:
src/component/1d-2d/components/FloatMoleculeStructures/DraggableStructure.tsx#L63
Avoid storing derived state. Instead, compute "bounding" directly during render
|