diff --git a/bert_sklearn/model/pytorch_pretrained/file_utils.py b/bert_sklearn/model/pytorch_pretrained/file_utils.py index 70a114c..6200fc8 100644 --- a/bert_sklearn/model/pytorch_pretrained/file_utils.py +++ b/bert_sklearn/model/pytorch_pretrained/file_utils.py @@ -290,7 +290,26 @@ def biobert_from_archive(archive_file, cache_dir, logger): resolved_archive_file, tempdir)) with tarfile.open(resolved_archive_file, 'r:gz') as archive: - archive.extractall(tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, tempdir) # i.e archive_file = 'biobert_v1.1_pubmed.tar.gz' filename = archive_file.split("/")[-1].split(".tar")[0] @@ -318,7 +337,26 @@ def scibert_from_archive(archive_file, cache_dir, logger): logger.info("extracting archive file {} to temp dir {}".format( resolved_archive_file, tempdir)) with tarfile.open(resolved_archive_file, 'r:tar') as archive: - archive.extractall(tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, tempdir) # i.e archive_file = 'scibert_scivocab_uncased.tar' serialization_dir = tempdir + "/" + archive_file.split("/")[-1].split(".tar")[0] @@ -328,7 +366,26 @@ def scibert_from_archive(archive_file, cache_dir, logger): weights_dir = serialization_dir + "/weights" with tarfile.open(weights_archive, 'r:gz') as archive: - archive.extractall(weights_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, weights_dir) bert_config = weights_dir + "/bert_config.json" pytorch_ckpt = weights_dir + "/pytorch_model.bin"