BLE Callbacks answer not complete?

[stefra1]

Is it possible that your answer of BLE Callbacks are not complete (maybe I don’t understand the FTMS spec)?

FTMS Tabel 4.23:
Response Code Op Code (0x80)
Request Op Code
Result Code
Response Parameter (if present)

Line 69..67 -> if (pData[0] == 0x01) //initiate procedure to reset treadmill
You answer with: 0x80 0x00
And I think it should be 0x80 0x01 0x00

Line 94..103 -> if (pData[0] == 0x03) //initiate procedure to set Incline
You answer with: 0x80 0x03
And I think it should be 0x80 0x03 0x01

Thanks for this project, it helps me a lot by upgrading my stepper with BLE!

[changer65535]

I am sure you are correct. Without a proper client/server, I had to fudge some stuff. In my case, the treadmill was able to complete the task without sending the correct response. Thank You For noticing this!! Chris

…

On Sat, Mar 28, 2020 at 12:00 PM stefra1 ***@***.***> wrote: Is it possible that your answer of BLE Callbacks are not complete (maybe I don’t understand the FTMS spec)? FTMS Tabel 4.23: Response Code Op Code (0x80) Request Op Code Result Code Response Parameter (if present) Line 69..67 -> if (pData[0] == 0x01) //initiate procedure to reset treadmill You answer with: 0x80 0x00 And I think it should be 0x80 0x01 0x00 Line 94..103 -> if (pData[0] == 0x03) //initiate procedure to set Incline You answer with: 0x80 0x03 And I think it should be 0x80 0x03 0x01 Thanks for this project, it helps me a lot by upgrading my stepper with BLE! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE4GXYQJNK4QQ2HSAIFCV5DRJYNKLANCNFSM4LVTYU7Q> .

[stefra1]

Another bug is that the treadmillData > ATT_MTU size
You have to transmit your Data in multiple notifications or reduce the size of the struct (and adapt the Flag Field).
I think this bug don’t matter for you, but maybe it’s helps somewhere else.

[changer65535]

Agreed! Thank You!

…

On Thu, Apr 2, 2020 at 12:58 PM stefra1 ***@***.***> wrote: Another bug is that the treadmillData > ATT_MTU size You have to transmit your Data in multiple notifications or reduce the size of the struct (and adapt the Flag Field). I think this bug don’t matter for you, but maybe it’s helps somewhere else. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE4GXYULW5NOM4PSHYXNL7DRKS74LANCNFSM4LVTYU7Q> .

[metas38]

you can fix this, with :
BLEDevice::setMTU(46);
in your InitBLE()
in your case, 34 might be enought
regards

[changer65535]

Very Nice!

…

Sent from my iPad

On May 1, 2020, at 8:33 AM, metas38 ***@***.***> wrote: you can fix this, with : BLEDevice::setMTU(46); in your InitBLE() in your case, 34 might be enought regards — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.