From 5623e09183b0b15bd881f7583ea66edf28dade6b Mon Sep 17 00:00:00 2001 From: jihoon796 Date: Sun, 27 Dec 2015 22:46:20 -0500 Subject: [PATCH 1/3] use duck typing and exceptions as well as spaces instead of tabs for PEP8 --- ystockquote.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/ystockquote.py b/ystockquote.py index 4bb388e..7965a13 100644 --- a/ystockquote.py +++ b/ystockquote.py @@ -13,7 +13,7 @@ # Requires: Python 2.7/3.3+ -__version__ = '0.2.5dev' +__version__ = '0.2.6dev' try: # py3 @@ -21,8 +21,9 @@ from urllib.parse import urlencode except ImportError: # py2 - from urllib2 import Request, urlopen from urllib import urlencode + from urllib2 import Request, urlopen + import datetime def _request(symbol, stat): @@ -464,11 +465,19 @@ def get_short_ratio(symbol): def get_historical_prices(symbol, start_date, end_date): """ Get historical prices for the given ticker symbol. - Date format is 'YYYY-MM-DD' + Date format is 'YYYY-MM-DD'. Also accepts datetime + in addition to strings. Returns a nested dictionary (dict of dicts). outer dict keys are dates ('YYYY-MM-DD') """ + try: + start_date = start_date.strftime('%Y-%m-%d') + end_date = end_date.strftime('%Y-%m-%d') + except AttributeError: + start_date = str(start_date) + end_date = str(end_date) + params = urlencode({ 's': symbol, 'a': int(start_date[5:7]) - 1, From 32d75e052873292b1df31ecf83fc7a98f08d2d26 Mon Sep 17 00:00:00 2001 From: jihoon796 Date: Sun, 27 Dec 2015 23:42:08 -0500 Subject: [PATCH 2/3] update import so it is alphabetical --- ystockquote.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ystockquote.py b/ystockquote.py index 7965a13..65d29c0 100644 --- a/ystockquote.py +++ b/ystockquote.py @@ -21,9 +21,9 @@ from urllib.parse import urlencode except ImportError: # py2 + import datetime from urllib import urlencode from urllib2 import Request, urlopen - import datetime def _request(symbol, stat): From 5ff686976ab0986e562ed8bd51136adbac6e7100 Mon Sep 17 00:00:00 2001 From: jihoon796 Date: Mon, 28 Dec 2015 17:47:07 -0500 Subject: [PATCH 3/3] add datetime to python 3 --- ystockquote.py | 1 + 1 file changed, 1 insertion(+) diff --git a/ystockquote.py b/ystockquote.py index 65d29c0..649965c 100644 --- a/ystockquote.py +++ b/ystockquote.py @@ -17,6 +17,7 @@ try: # py3 + import datetime from urllib.request import Request, urlopen from urllib.parse import urlencode except ImportError: