[RFC] Allow payload for GET request too. (The same as POST, PUT, and other requests)

[realshovanshah]

New Issue Checklist

• I have searched for a similar issue in the project and found Sending a JSON body with GET request? #252 , but it was closed.
• Make necessary changes for supporting request body in GET request.

As of version 4.0.3, there's no support for adding request body to GET requests.

This was previously discussed in #252 and I this has been solved yet. This should be an open issue, so I'm reopening this.

I'm in need of for a project. I'll try to send a pull request if I'm free.
Do let us know if anyone is interested in helping close this issue.

[wendux]

Oh... it is not a normal operation to carry a body in a GET request, and the browsers do not support it too...

[realshovanshah]

Yes, but there's nothing stopping a backend from adding request body to a GET request. Though browsers don't support it, I'd like to argue that many other client libraries do support this, and it's for a reason.

After further research I found this- Even Elasticsearch makes use the above mentioned feature.
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-body.html

[wendux]

OK..Let's discuss it together，I want to hear more people's thoughts！

[jgoyvaerts]

We could add this in a 5.0, and maybe consider that this requires a specific flag to be set on the request.

Why a flag and not just an optional body parameter?

[mykolamor]

I've left an issue #1422 before finding this thread, I think all methods should be allowed to have a body if a user passes it in the request.

[ntta]

I'm struggling with the issue of a GET method with a body as well. After a while of digging on the internet, I found the answer on StackOverflow.

Refer to: https://stackoverflow.com/questions/978061/http-get-with-request-body#:~:text=The%20RFC2616%20referenced,was%20deleted

Years ago, it seems to be a bad practice to use body parameters for a GET request. However, now it should be an acceptable/valid practice for building a GET request like that. I just have a quick thought about an e-commerce website with many different types of filters (e.g.: brand, price range, category, seller name, etc.). Should it be more controllable if we have this kind of filter in a body?

As a back-end API dev, we can change it to a POST request. However, in my opinion, if I use a POST request, I want to change/update something in the database. And a GET method in the above example is exactly what I want to use.

I bet this "new" practice is relying on the evolving of data on the internet 😄

So, last but not least, hope that Dio can have this option in the next update.

Cheers!

[Prn-Ice]

If it works on postman, it should work on dio 😄

[HenryEffiong]

Many back-end API still do this use a body parameter for a GET request. Just encountered one that led me all the way here. The flexibility of having this is option in Dio is much welcomed

[AlexV525]

This has been implemented.