fix(catalog): remove cards without printings

Amp-Thread-ID: https://ampcode.com/threads/T-019fe6e8-e7e4-779a-a885-4bb102e9a711

Author: cfbender

lib/manavault/catalog/scryfall/import.ex

@@ -394,12 +394,30 @@ defmodule Manavault.Catalog.Scryfall.Import do
           Repo.delete_all(from printing in Printing, where: printing.scryfall_id in ^ids)
         end)
 
+        delete_cards_without_printings()
+
         {:ok, :reconciled}
       end,
       timeout: :infinity
     )
   end
 
+  defp delete_cards_without_printings do
+    orphaned_card_ids =
+      Repo.all(
+        from card in Card,
+          left_join: printing in Printing,
+          on: printing.oracle_id == card.oracle_id,
+          where: is_nil(printing.scryfall_id),
+          select: card.oracle_id
+      )
+
+    Enum.each(Enum.chunk_every(orphaned_card_ids, @batch_size), fn ids ->
+      Repo.delete_all(from deck_card in DeckCard, where: deck_card.oracle_id in ^ids)
+      Repo.delete_all(from card in Card, where: card.oracle_id in ^ids)
+    end)
+  end
+
   defp replacement_for(_stale, []), do: nil
 
   defp replacement_for(stale, replacements) do

priv/repo/migrations/20260809000000_delete_cards_without_printings.exs

@@ -0,0 +1,29 @@
+defmodule Manavault.Repo.Migrations.DeleteCardsWithoutPrintings do
+  use Ecto.Migration
+
+  import Ecto.Query
+
+  @batch_size 200
+
+  def up do
+    orphaned_card_ids =
+      repo().all(
+        from(card in "scryfall_cards",
+          left_join: printing in "scryfall_printings",
+          on: printing.oracle_id == card.oracle_id,
+          where: is_nil(printing.scryfall_id),
+          select: card.oracle_id
+        )
+      )
+
+    Enum.each(Enum.chunk_every(orphaned_card_ids, @batch_size), fn ids ->
+      repo().delete_all(from(deck_card in "deck_cards", where: deck_card.oracle_id in ^ids))
+      repo().delete_all(from(card in "scryfall_cards", where: card.oracle_id in ^ids))
+    end)
+  end
+
+  def down do
+    # Deleted catalog and deck-card rows cannot be reconstructed.
+    :ok
+  end
+end

test/manavault/catalog/sync_test.exs

@@ -148,6 +148,43 @@ defmodule Manavault.Catalog.SyncTest do
     assert Repo.get!(DeckAllocation, allocation.id).collection_item_id == item.id
   end
 
+  test "sync_scryfall deletes cards left without paper printings" do
+    digital_only = %{
+      @black_lotus
+      | "id" => "digital-only-printing",
+        "oracle_id" => "digital-only-oracle",
+        "name" => "Digital Only Card",
+        "games" => ["arena"]
+    }
+
+    assert {:ok, %{cards_count: 1, printings_count: 1}} =
+             Catalog.import_cards([digital_only])
+
+    assert {:ok, deck} = Catalog.create_deck(%{"name" => "Digital Only Deck"})
+
+    assert {:ok, deck_card} =
+             Catalog.add_card_to_deck(deck, %{"name" => digital_only["name"], "quantity" => 1})
+
+    metadata_url = "https://example.test/orphan-cleanup-metadata"
+    download_url = "https://example.test/orphan-cleanup-default-cards.jsonl.gz"
+
+    fetcher = fn
+      ^metadata_url -> {:ok, Jason.encode!(%{"jsonl_download_uri" => download_url})}
+      ^download_url -> {:ok, gzip_jsonl([@black_lotus])}
+    end
+
+    assert {:ok, %Sync{status: "succeeded"}} =
+             Catalog.sync_scryfall(
+               fetcher: fetcher,
+               bulk_url: metadata_url,
+               oracle_tags_bulk_url: nil
+             )
+
+    refute Repo.get(Printing, digital_only["id"])
+    refute Repo.get(Card, digital_only["oracle_id"])
+    refute Repo.get(DeckCard, deck_card.id)
+  end
+
   test "sync_scryfall deletes existing memorabilia and token set printings" do
     memorabilia =
       %{