Skip to content

Commit 2987f11

Browse files
committed
chore: remove unique card count from deck
1 parent dee04f7 commit 2987f11

7 files changed

Lines changed: 26 additions & 41 deletions

File tree

‎assets/react/src/gql/gql.ts‎

Lines changed: 12 additions & 12 deletions
Large diffs are not rendered by default.

‎assets/react/src/gql/graphql.ts‎

Lines changed: 8 additions & 8 deletions
Large diffs are not rendered by default.

‎assets/react/src/pages/decks/detail-page-content.tsx‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,6 @@ export function DeckDetailContent({
203203
<Badge tone={deck.status === "active" ? "success" : "neutral"}>
204204
{titleize(deck.status)}
205205
</Badge>
206-
<span className="inline-flex h-5 items-center">
207-
{compactNumber(deck.uniqueCardCount || 0)} unique
208-
</span>
209206
<Badge tone={deckLegalityTone(deck.legality)}>{deckLegalityLabel(deck.legality)}</Badge>
210207
<BuylistPriceChip
211208
price={buylistPrice}

‎assets/react/src/pages/decks/list-page.tsx‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,6 @@ export function DecksPage() {
8888
<Badge tone={deck.status === "active" ? "success" : "neutral"}>
8989
{titleize(deck.status)}
9090
</Badge>
91-
<span className="inline-flex h-5 items-center">
92-
{compactNumber(deck.uniqueCardCount || 0)} unique
93-
</span>
9491
<Badge tone={deckLegalityTone(deck.legality)}>
9592
{deckLegalityLabel(deck.legality)}
9693
</Badge>

‎assets/react/src/pages/decks/queries.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export const DecksDocument = graphql(`
1717
coverImageUrl
1818
commanderColorIdentity
1919
cardCount
20-
uniqueCardCount
2120
legality {
2221
status
2322
issues {
@@ -45,7 +44,6 @@ export const CreateDeckDocument = graphql(`
4544
coverImageUrl
4645
commanderColorIdentity
4746
cardCount
48-
uniqueCardCount
4947
legality {
5048
status
5149
issues {
@@ -72,7 +70,6 @@ export const UpdateDeckDocument = graphql(`
7270
coverImageUrl
7371
commanderColorIdentity
7472
cardCount
75-
uniqueCardCount
7673
legality {
7774
status
7875
issues {
@@ -157,7 +154,6 @@ export const DeckDocument = graphql(`
157154
status
158155
shareToken
159156
cardCount
160-
uniqueCardCount
161157
legality {
162158
status
163159
issues {

‎lib/manavault_web/deck_share_preview.ex‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ defmodule ManavaultWeb.DeckSharePreview do
3131

3232
def from_deck(%Deck{} = deck, token) when is_binary(token) do
3333
card_count = Catalog.deck_card_count(deck)
34-
unique_card_count = Catalog.deck_unique_card_count(deck)
3534
format_label = titleize(deck.format)
3635
legality = Catalog.deck_legality(deck)
3736
legality_label = legality_label(legality)
@@ -46,8 +45,7 @@ defmodule ManavaultWeb.DeckSharePreview do
4645
token: token,
4746
deck_name: deck_name,
4847
title: "#{deck_name} · ManaVault",
49-
description:
50-
deck_description(format_label, card_count, unique_card_count, legality_label, price_label),
48+
description: deck_description(format_label, card_count, legality_label, price_label),
5149
image_alt: "Preview for #{deck_name}",
5250
image_type: "image/svg+xml",
5351
image_url: nil,
@@ -58,7 +56,6 @@ defmodule ManavaultWeb.DeckSharePreview do
5856
format_label: format_label,
5957
status_label: titleize(deck.status),
6058
card_count_label: "#{compact_number(card_count)} cards",
61-
unique_count_label: "#{compact_number(unique_card_count)} unique",
6259
legality_label: legality_label,
6360
price_label: price_label,
6461
color_identity: Catalog.deck_commander_color_identity(deck) || []
@@ -69,8 +66,7 @@ defmodule ManavaultWeb.DeckSharePreview do
6966
deck_name = one_line(preview.deck_name)
7067
title_size = title_font_size(deck_name)
7168
deck_name = truncate_for_width(deck_name, title_width(preview.color_identity), title_size)
72-
unique_x = 72 + badge_width(preview.status_label) + 28
73-
legality_x = unique_x + text_width(preview.unique_count_label, 27) + 28
69+
legality_x = 72 + badge_width(preview.status_label) + 20
7470
price_x = legality_x + badge_width(preview.legality_label) + 20
7571
symbol_resolver = Keyword.get(opts, :symbol_resolver, &mana_symbol_url/1)
7672

@@ -113,7 +109,6 @@ defmodule ManavaultWeb.DeckSharePreview do
113109
#{mana_symbols(preview.color_identity, symbol_resolver)}
114110
115111
#{badge(72, 432, preview.status_label, :success)}
116-
<text x="#{unique_x}" y="469" fill="#e7dfdf" fill-opacity="0.74" font-size="27" font-weight="650">#{xml_escape(preview.unique_count_label)}</text>
117112
#{badge(legality_x, 432, preview.legality_label, legality_tone(preview.legality_label))}
118113
#{badge(price_x, 432, preview.price_label, :warning)}
119114
@@ -149,11 +144,10 @@ defmodule ManavaultWeb.DeckSharePreview do
149144
File.Error -> {:error, :render_failed}
150145
end
151146

152-
defp deck_description(format_label, card_count, unique_card_count, legality_label, price_label) do
147+
defp deck_description(format_label, card_count, legality_label, price_label) do
153148
[
154149
"#{format_label} deck",
155150
"#{compact_number(card_count)} cards",
156-
"#{compact_number(unique_card_count)} unique",
157151
legality_label,
158152
price_label
159153
]

‎test/manavault_web/controllers/app_controller_test.exs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ defmodule ManavaultWeb.AppControllerTest do
2626
assert response =~ ~s|property="og:title" content="Lotus Lessons · ManaVault"|
2727

2828
assert response =~
29-
~s|property="og:description" content="Commander deck, 100 cards, 2 unique, Legal, $256.76."|
29+
~s|property="og:description" content="Commander deck, 100 cards, Legal, $256.76."|
30+
refute response =~ "unique"
3031

3132
assert response =~
3233
~s|property="og:image" content="http://www.example.com/share/decks/#{token}/preview.png"|
@@ -49,7 +50,7 @@ defmodule ManavaultWeb.AppControllerTest do
4950
assert response =~ "Lotus Lessons"
5051
assert response =~ "Commander"
5152
assert response =~ "100 cards"
52-
assert response =~ "2 unique"
53+
refute response =~ "unique"
5354
assert response =~ "Legal"
5455
assert response =~ "$256.76"
5556
assert response =~ "data:image/svg+xml"

0 commit comments

Comments
 (0)