From eb16572b5ab3503d9d3a335c7a1540ef3975772f Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Fri, 18 Nov 2022 23:00:11 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- .../trackoptions/InputOutputSelectorOptionHandlerTest.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dash.fragmencrypter/src/test/java/com/castlabs/dash/dashfragmenter/cmdlines/trackoptions/InputOutputSelectorOptionHandlerTest.java b/dash.fragmencrypter/src/test/java/com/castlabs/dash/dashfragmenter/cmdlines/trackoptions/InputOutputSelectorOptionHandlerTest.java index 62e44b2..f23efc6 100644 --- a/dash.fragmencrypter/src/test/java/com/castlabs/dash/dashfragmenter/cmdlines/trackoptions/InputOutputSelectorOptionHandlerTest.java +++ b/dash.fragmencrypter/src/test/java/com/castlabs/dash/dashfragmenter/cmdlines/trackoptions/InputOutputSelectorOptionHandlerTest.java @@ -8,6 +8,7 @@ import java.io.File; import java.io.IOException; +import java.nio.file.Files; public class InputOutputSelectorOptionHandlerTest { @@ -20,7 +21,7 @@ public class Main { public void test1() throws CmdLineException, IOException { Main m = new Main(); CmdLineParser cmdLineParser = new CmdLineParser(m); - File f = File.createTempFile("aaa", ".jpg"); + File f = Files.createTempFile("aaa", ".jpg").toFile(); cmdLineParser.parseArgument(f.getParent() + "/*.jpg[vtiles=5,htiles=6,thduration=7]"); Assert.assertEquals("5", m.i.getOutputOptions().get("vtiles")); Assert.assertEquals("6", m.i.getOutputOptions().get("htiles")); @@ -33,8 +34,8 @@ public void test1() throws CmdLineException, IOException { public void test2() throws CmdLineException, IOException { Main m = new Main(); CmdLineParser cmdLineParser = new CmdLineParser(m); - File f = File.createTempFile("aaa", ".jpghhh"); + File f = Files.createTempFile("aaa", ".jpghhh").toFile(); cmdLineParser.parseArgument(f.getParent() + "/*.jpghhh[vtiles=5,htiles=6,thduration=7]"); } -} \ No newline at end of file +}