From 81cdb76b1a770d1b320cd3bd9cde1b9fedf9ac78 Mon Sep 17 00:00:00 2001 From: javierdelapuente Date: Thu, 27 Nov 2025 09:15:53 +0100 Subject: [PATCH 1/4] Fix styleguide in CONTRIBUTING.md Corrected the link text for charm development best practices. --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 78269e2..5e2d4c7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ - [Test Structure](#test-structure) - [Type Hints](#type-hints) -The [Charm development best practices](https://juju.is/docs/sdk/styleguide) are +The [How to write and structure charm code]([https://juju.is/docs/sdk/styleguide](https://documentation.ubuntu.com/ops/latest/howto/write-and-structure-charm-code) is incorporated by reference. ## Definitions From 1b3540eaa7a1ddd18b75cc8793fbe0387999df01 Mon Sep 17 00:00:00 2001 From: javierdelapuente Date: Thu, 27 Nov 2025 09:20:49 +0100 Subject: [PATCH 2/4] Fix link formatting in CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5e2d4c7..c5ee9aa 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ - [Test Structure](#test-structure) - [Type Hints](#type-hints) -The [How to write and structure charm code]([https://juju.is/docs/sdk/styleguide](https://documentation.ubuntu.com/ops/latest/howto/write-and-structure-charm-code) is +The [How to write and structure charm code](https://documentation.ubuntu.com/ops/latest/howto/write-and-structure-charm-code) is incorporated by reference. ## Definitions From 0fc354f1fdfb302d0a2a1a0902584543e3d906fc Mon Sep 17 00:00:00 2001 From: Javier de la Puente Date: Thu, 27 Nov 2025 10:40:33 +0100 Subject: [PATCH 3/4] try to split the line in markdown --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c5ee9aa..b3e0ba0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,8 +20,9 @@ - [Test Structure](#test-structure) - [Type Hints](#type-hints) -The [How to write and structure charm code](https://documentation.ubuntu.com/ops/latest/howto/write-and-structure-charm-code) is -incorporated by reference. +The +[How to write and structure charm code](https://documentation.ubuntu.com/ops/latest/howto/write-and-structure-charm-code) +is incorporated by reference. ## Definitions From 4f89c1e099515110191337e4c0ce376b8c2d6cb5 Mon Sep 17 00:00:00 2001 From: Javier de la Puente Date: Thu, 27 Nov 2025 10:43:06 +0100 Subject: [PATCH 4/4] use a specific runner (to not get s390x) --- .github/workflows/markdownlint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdownlint.yaml b/.github/workflows/markdownlint.yaml index a7c79ee..a4d1386 100644 --- a/.github/workflows/markdownlint.yaml +++ b/.github/workflows/markdownlint.yaml @@ -5,7 +5,7 @@ on: jobs: mdl: - runs-on: [self-hosted, edge] + runs-on: [self-hosted-linux-amd64-noble-edge] steps: - name: Check out code uses: actions/checkout@v6