From edfe28aa9221a925f8f7a76762aa2883c69d3d17 Mon Sep 17 00:00:00 2001 From: Cameron Rye Date: Thu, 13 Nov 2025 14:44:59 -0500 Subject: [PATCH] fix: enhance build verification in CI and release workflows - Add comprehensive checks for example site build artifacts - Verify index.html, assets directory, and CSS files exist - Add detailed error messages for missing artifacts - Prevent false positives in dry run mode - Improve library artifact verification in CI workflow This fixes the issue where dry run would pass even if the build didn't produce the expected output files. --- .github/workflows/ci.yml | 13 +++++++++++-- .github/workflows/release.yml | 7 ++++++- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a0f20d8..26702a5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -43,6 +43,15 @@ jobs: - name: Check for build artifacts run: | - test -f packages/frostpane/dist/frostpane.css || exit 1 - test -d packages/example/dist || exit 1 + echo "Checking library build artifacts..." + test -f packages/frostpane/dist/frostpane.css || (echo "❌ frostpane.css not found" && exit 1) + test -f packages/frostpane/dist/frostpane-core.css || (echo "❌ frostpane-core.css not found" && exit 1) + echo "✅ Library artifacts present" + + echo "Checking example site build artifacts..." + test -d packages/example/dist || (echo "❌ Example dist directory not found" && exit 1) + test -f packages/example/dist/index.html || (echo "❌ index.html not found" && exit 1) + test -d packages/example/dist/assets || (echo "❌ assets directory not found" && exit 1) + ls packages/example/dist/assets/*.css >/dev/null 2>&1 || (echo "❌ No CSS files found in assets" && exit 1) + echo "✅ Example site artifacts present" diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 60d5b96..fb0552a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -85,7 +85,12 @@ jobs: - name: Verify example build run: | - test -d packages/example/dist || (echo "❌ Example dist not found" && exit 1) + echo "Checking example site build artifacts..." + test -d packages/example/dist || (echo "❌ Example dist directory not found" && exit 1) + test -f packages/example/dist/index.html || (echo "❌ index.html not found" && exit 1) + test -d packages/example/dist/assets || (echo "❌ assets directory not found" && exit 1) + # Verify at least one CSS file exists in assets + ls packages/example/dist/assets/*.css >/dev/null 2>&1 || (echo "❌ No CSS files found in assets" && exit 1) echo "✅ Example site built successfully" - name: Push changes