Loving dockerize - and have been tinkering to see how it could work at work where, unfortunately, we have to use an internal gitlab instance rather than the glorious github.
Where I've got to is to replace the github sub-command with a git one which takes a full git url rather than "just the end bit". As well as supporting our internal gitlab and the existing github it allows images to be built from e.g. the local filesystem or git repos in a simple ssh account.
Downsides I can think of for this are that it means having to enter less convenient references for repos, and it would be a breaking change. I guess it could be possible to support both subcommands, but that just feels like it would be messy for maintenance. Hence me firing this off before proposing an actual pull request - I'd be really interested in your thoughts.
I have forked a version (https://github.com/roovo/dockerize) with this in place if you want to have a look/play and see what you think. I should just say that I also made specifying the branch a command line option as part of this, as the branch name does not form part of a git url (hence it felt wrong to add a :branch on the end).
Very interested in further discussions on this and potentially more than happy to prepare a pull request when/if a workable/agreeable solution is found.
Cheers
Roovo
Loving dockerize - and have been tinkering to see how it could work at work where, unfortunately, we have to use an internal gitlab instance rather than the glorious github.
Where I've got to is to replace the github sub-command with a git one which takes a full git url rather than "just the end bit". As well as supporting our internal gitlab and the existing github it allows images to be built from e.g. the local filesystem or git repos in a simple ssh account.
Downsides I can think of for this are that it means having to enter less convenient references for repos, and it would be a breaking change. I guess it could be possible to support both subcommands, but that just feels like it would be messy for maintenance. Hence me firing this off before proposing an actual pull request - I'd be really interested in your thoughts.
I have forked a version (https://github.com/roovo/dockerize) with this in place if you want to have a look/play and see what you think. I should just say that I also made specifying the branch a command line option as part of this, as the branch name does not form part of a git url (hence it felt wrong to add a :branch on the end).
Very interested in further discussions on this and potentially more than happy to prepare a pull request when/if a workable/agreeable solution is found.
Cheers
Roovo