test(ios): cover WebDriver snapshot seams

Author: thymikee

packages/provider-webdriver/src/webdriver-interactor.test.ts

@@ -269,6 +269,26 @@ test('iOS WebDriver interactor routes snapshots through the acquisition adapter'
   assert.equal(result.nodes?.[0]?.type, 'XCUIElementTypeApplication');
 });
 
+test('Android WebDriver interactor keeps legacy-derived source facts at its call site', async () => {
+  const source = vi.fn(
+    async () =>
+      '<hierarchy rotation="0"><android.widget.Button bounds="[0,0][100,40]" displayed="true" enabled="true" /></hierarchy>',
+  );
+  const interactor = createWebDriverInteractor({
+    client: { source } as unknown as WebDriverClient,
+    backend: 'android',
+    capabilities: createCloudWebDriverCapabilities({ provider: 'test', platform: 'android' }),
+  });
+
+  const result = await interactor.snapshot();
+
+  assert.equal(result.backend, 'android');
+  assert.equal(result.nodes?.[0]?.type, 'hierarchy');
+  assert.equal(result.nodes?.[1]?.type, 'android.widget.Button');
+  assert.equal(result.nodes?.[1]?.hittable, true);
+  assert.equal(source.mock.calls.length, 1);
+});
+
 async function runFill(world: ReturnType<typeof createTextEntryWorld>) {
   vi.useFakeTimers();
   try {

packages/provider-webdriver/src/webdriver-ios-snapshot.test.ts

@@ -33,8 +33,17 @@ test('Appium iOS snapshots acquire facts and publish regular output through the
   assert.equal(result.nodes?.find((node) => node.label === 'Continue')?.hittable, false);
   assert.equal(source.mock.calls.length, 1);
   assert.ok(result.warnings?.some((warning) => warning.includes('hittability evidence')));
-  assert.equal(JSON.stringify(result).includes('iosSnapshot'), false);
-  assert.equal(JSON.stringify(result).includes('apple-runner'), false);
+  assert.deepEqual(Object.keys(result).sort(), [
+    'backend',
+    'nodes',
+    'producer',
+    'truncated',
+    'warnings',
+  ]);
+  assert.equal(
+    result.nodes?.every((node) => !('ref' in node)),
+    true,
+  );
 });
 
 test('Appium iOS options become an engine plan and engine-owned projection', () => {
@@ -102,10 +111,11 @@ test('Appium iOS regular presentation fails typed when page source has no viewpo
   ]);
   assert.throws(
     () => publishWebDriverIosSnapshot(acquired),
-    (error: unknown) =>
-      error instanceof AppError &&
-      error.details?.reason === 'missing-viewport' &&
-      !('iosSnapshotEngine' in (error.details ?? {})),
+    (error: unknown) => {
+      assert.ok(error instanceof AppError);
+      assert.deepEqual(error.details, { reason: 'missing-viewport', field: 'viewport' });
+      return true;
+    },
   );
 });
 

test/integration/provider-scenarios/cloud-webdriver-ios-text-entry.test.ts

@@ -62,6 +62,55 @@ test('cloud iOS snapshot captures through the provider session after open', asyn
   });
 }, 15_000);
 
+test('cloud iOS engine-presented snapshot survives daemon publication', async () => {
+  await withProviderScenarioResource(createCloudIosWorld, async ({ daemon, server }) => {
+    const lease = await openCloudIosSession(daemon);
+    server.sourceOverride =
+      '<XCUIElementTypeApplication name="Demo" x="0" y="0" width="390" height="844">' +
+      '<XCUIElementTypeNavigationBar name="Team Standup" x="0" y="56" width="390" height="44">' +
+      '<XCUIElementTypeStaticText label="Team Standup" x="219" y="58" width="85" height="40" />' +
+      '<XCUIElementTypeButton label="Video Call" x="300" y="56" width="46" height="44" />' +
+      '<XCUIElementTypeTextField label="Team Standup" value="Team Standup" name="DisplayNameTextField" enabled="false" x="100" y="67" width="113" height="22" />' +
+      '<XCUIElementTypeImage name="RoomDetailsIconImageView" x="81" y="80" width="14" height="14" />' +
+      '</XCUIElementTypeNavigationBar>' +
+      '<XCUIElementTypeTable label="Team Standup" x="0" y="100" width="390" height="600">' +
+      '<XCUIElementTypeCell label="Team Standup" x="0" y="100" width="390" height="297">' +
+      '<XCUIElementTypeButton label="Team Standup" x="20" y="200" width="362" height="27" />' +
+      '</XCUIElementTypeCell>' +
+      '</XCUIElementTypeTable>' +
+      '</XCUIElementTypeApplication>';
+
+    const response = await daemon.callCommand(
+      'snapshot',
+      [],
+      { ...leaseFlags(lease.leaseId), snapshotInteractiveOnly: true },
+      { meta: leaseMeta(lease.leaseId) },
+    );
+
+    const data = assertRpcOk<{
+      nodes?: Array<{ type?: string; label?: string; identifier?: string; enabled?: boolean }>;
+    }>(response);
+    assert.equal(
+      data.nodes?.some(
+        (node) =>
+          node.type === 'Button' &&
+          node.label === 'Team Standup' &&
+          node.identifier === 'DisplayNameTextField' &&
+          node.enabled === true,
+      ),
+      true,
+    );
+    assert.equal(
+      data.nodes?.some((node) => node.type === 'StaticText' && node.label === 'Team Standup'),
+      false,
+    );
+    assert.equal(
+      data.nodes?.some((node) => node.identifier === 'RoomDetailsIconImageView'),
+      false,
+    );
+  });
+}, 15_000);
+
 /**
  * #1658: `fill` tapped and sent its keys back-to-back. A WebView input takes
  * first responder asynchronously, so the keys arrived with nothing focused and
@@ -254,6 +303,7 @@ class FakeIosWebDriverServer extends CloudWebDriverTestServer {
   pollsUntilFocus = 1;
   fieldValues: Record<FieldName, string> = { email: '', password: '' };
   focused: FieldName | undefined;
+  sourceOverride: string | undefined;
 
   private pollsRemaining = Number.POSITIVE_INFINITY;
   private pendingFocus: FieldName | undefined;
@@ -373,6 +423,7 @@ class FakeIosWebDriverServer extends CloudWebDriverTestServer {
   }
 
   private source(): string {
+    if (this.sourceOverride !== undefined) return this.sourceOverride;
     const field = (name: FieldName, label: string) =>
       `<XCUIElementTypeTextField name="${name}" label="${label}" value="${this.fieldValues[name]}" ` +
       `x="${FIELDS[name].x}" y="${FIELDS[name].y}" width="${FIELDS[name].width}" ` +