fix(daemon): move close's admission bypass into the command-descriptor registry

Review on #2029, P1: request-admission.ts was reclassifying req.command and
req.positionals inline instead of consuming a registry predicate (ADR-0003).
Added a request-sensitive DaemonCommandDescriptor trait,
sessionlessPlainCloseAdmissionExempt, declared on close's descriptor via a
named predicate (isPlainCloseRequest); request-admission.ts now asks the
registry (isSessionlessPlainCloseAdmissionExempt) instead of matching
req.command === 'close' and req.positionals.length itself.

P2: reverted the workflow help-card byte-budget bump from #2030bd (9000 ->
9100) back to 9000, and instead trimmed the "Bootstrap" help line by the
minimum amount ("or one provider" -> "or provider",
"providers never fall back" -> "no provider fallback") to fit the existing
budget with a small margin (8994 bytes). That budget regression came from
#2020 on main, unrelated to this PR's close/lease-admission fix.

Author: thymikee

src/__tests__/cli-help.test.ts

@@ -75,7 +75,7 @@ test('help workflow prints the compact workflow card with a version header and s
   assert.equal(result.calls.length, 0);
   assert.match(result.stdout, /^agent-device \S+ — workflow/);
   assert.ok(
-    Buffer.byteLength(result.stdout, 'utf8') < 9100,
+    Buffer.byteLength(result.stdout, 'utf8') < 9000,
     `help workflow should stay close to the compact-card size target, was ${Buffer.byteLength(result.stdout, 'utf8')} bytes`,
   );
   assert.match(result.stdout, /open -> snapshot -i -> settle -> verify -> close loop/);

src/cli-schema/cli-help-topics.test.ts

@@ -119,7 +119,7 @@ test('usageForCommand resolves workflow help topic', async () => {
   if (help === null) throw new Error('Expected workflow help text');
   assert.match(help, /^agent-device \S+ — workflow/);
   assert.ok(
-    Buffer.byteLength(help, 'utf8') < 9100,
+    Buffer.byteLength(help, 'utf8') < 9000,
     `workflow help topic should stay close to the compact-card size target, was ${Buffer.byteLength(help, 'utf8')} bytes`,
   );
   assert.match(help, /open -> snapshot -i -> settle -> verify -> close loop/);
@@ -138,7 +138,7 @@ test('usageForCommand resolves workflow help topic', async () => {
   assert.match(help, /Shapes and platform quirks: help gestures/);
   assert.match(
     help,
-    /open --foreground -> snapshot\. Selection: explicit --device\/--udid\/--serial, then session, booted\/bootable local, or one provider; --platform\/--target only filter\./,
+    /open --foreground -> snapshot\. Selection: explicit --device\/--udid\/--serial, then session, booted\/bootable local, or provider; --platform\/--target only filter\./,
   );
   assert.match(help, /Never open artifact paths or invent package ids/);
   assert.match(

src/cli-schema/cli-help.ts

@@ -134,7 +134,7 @@ Command shape:
   Gestures: scroll/swipe for lists/flicks; gesture pan|fling|pinch|rotate|transform|drag for multi-touch. Shapes and platform quirks: help gestures.
 
 Bootstrap:
-  open --foreground -> snapshot. Selection: explicit --device/--udid/--serial, then session, booted/bootable local, or one provider; --platform/--target only filter. Ambiguous/empty fails with bounded retry selectors; providers never fall back.
+  open --foreground -> snapshot. Selection: explicit --device/--udid/--serial, then session, booted/bootable local, or provider; --platform/--target only filter. Ambiguous/empty fails with bounded retry selectors; no provider fallback.
   Install arguments are app/package id then artifact path: agent-device install com.example.app ./dist/app.apk --platform android, then open <id> --relaunch for fresh state. Use reinstall only when explicitly requested.
   Unknown app id: devices, then apps, then open <discovered-app-id>. Never open artifact paths or invent package ids; ask if lookup misses the target.
   Apple CI: prepare ios-runner after boot/install, before replay/test (help prepare). Remote/cloud: connect -> open -> commands -> close -> disconnect (help remote). Reusable scripts, secret-safe fills, replay repair: help scripting.

src/core/command-descriptor/registry.ts

@@ -170,6 +170,14 @@ const isShardedTestRequest = (req: DispatchedCommand): boolean =>
   req.command === 'test' &&
   (typeof req.flags?.shardAll === 'number' || typeof req.flags?.shardSplit === 'number');
 
+// #2016: a plain `close` (no app-target positional) has nothing to close via
+// flags, so it's the only close shape eligible for the sessionless
+// no-lease-anywhere admission bypass in request-admission.ts. `close <app>`
+// resolves its device straight from flags when there's no session and must
+// stay behind full lease/tenant admission.
+const isPlainCloseRequest = (req: DispatchedCommand): boolean =>
+  (req.positionals?.length ?? 0) === 0;
+
 // ADR 0014 request-sensitive ref-frame resolvers. The action is the leading
 // positional (see keyboard/alert daemon writers in src/commands/system/index.ts
 // and src/commands/capture/alert.ts). Only the read-only status probes preserve
@@ -922,6 +930,7 @@ export const RAW_COMMAND_DESCRIPTORS = [
       refFrameEffect: 'may-invalidate',
       allowInvalidRecording: true,
       saveScriptFlagOwner: true,
+      sessionlessPlainCloseAdmissionExempt: isPlainCloseRequest,
     },
     timeoutPolicy: DEFAULT_TIMEOUT_POLICY,
     batchable: true,

src/daemon/daemon-command-registry.ts

@@ -44,6 +44,17 @@ export type DaemonCommandDescriptor = {
   preferExplicitDeviceOverExistingSession?: boolean;
   allowSessionlessDefaultDevice?: (req: DaemonRequest) => boolean;
   skipSessionlessProviderDevice?: (req: DaemonRequest) => boolean;
+  /**
+   * #2016: this request shape is eligible for the sessionless,
+   * no-lease-anywhere lease-admission bypass — a session that was never
+   * created (deferred `connect`, `open` never ran) has no lease to admit or
+   * release. Only `close` declares it, and only for the plain-close shape
+   * (no app-target positional): `close <app>` resolves its device straight
+   * from flags when there's no session, so it must stay behind full
+   * lease/tenant admission. Declared here so `request-admission.ts` asks the
+   * registry instead of reclassifying `req.command`/`req.positionals` itself.
+   */
+  sessionlessPlainCloseAdmissionExempt?: (req: DaemonRequest) => boolean;
 };
 
 export type DaemonProviderDeviceResolutionIntent =
@@ -121,6 +132,12 @@ export function usesSessionlessDefaultProviderDevice(req: DaemonRequest): boolea
   return typeof allow === 'function' ? allow(req) : false;
 }
 
+/** #2016: whether this request qualifies for the sessionless plain-close lease-admission bypass. */
+export function isSessionlessPlainCloseAdmissionExempt(req: DaemonRequest): boolean {
+  const exempt = getDaemonCommandDescriptor(req.command)?.sessionlessPlainCloseAdmissionExempt;
+  return typeof exempt === 'function' ? exempt(req) : false;
+}
+
 /**
  * ADR 0014: the ref-frame effect a request resolves to, honoring the
  * request-sensitive resolver form. Returns `undefined` for commands with no

src/daemon/request-admission.ts

@@ -1,7 +1,10 @@
 import { AppError } from '@agent-device/kernel/errors';
 import { normalizeTenantId, resolveSessionIsolationMode } from './config.ts';
 import { isTenantOwnedSessionName, tenantScopedSessionName } from './session-tenant-scope.ts';
-import { isLeaseAdmissionExempt } from './daemon-command-registry.ts';
+import {
+  isLeaseAdmissionExempt,
+  isSessionlessPlainCloseAdmissionExempt,
+} from './daemon-command-registry.ts';
 import {
   DEFAULT_PROXY_LEASE_TTL_MS,
   findMissingProxyLeaseFields,
@@ -69,22 +72,22 @@ export function assertRequestLeaseAdmission(
   const requestLeaseScope = resolveLeaseScope(req);
   assertProxyOpenLeaseMetadata(req, requestLeaseScope);
   const sessionLease = session?.lease;
-  // #2016: plain `close` (no app target) on a tenant-isolated connection
-  // that never reached `open` has no daemon session and no lease to admit
-  // or release. Falling through would make the generic tenant/run/lease
-  // check below throw "tenant isolation requires lease id.", which reads as
-  // an access-control failure instead of "nothing to close". Let the close
-  // handler's own session lookup return its SESSION_NOT_FOUND response
-  // instead. Requires `session === undefined`, not just a lease-less
-  // session: a *stored* session under tenant isolation is keyed by tenant,
-  // not by run, so a lease-less stored session could belong to another run
-  // in the same tenant — admission must still verify a matching lease
-  // before that run's session can be torn down.
+  // #2016: a tenant-isolated connection that never reached `open` has no
+  // daemon session and no lease to admit or release. Falling through would
+  // make the generic tenant/run/lease check below throw "tenant isolation
+  // requires lease id.", which reads as an access-control failure instead of
+  // "nothing to close". Let the close handler's own session lookup return
+  // its SESSION_NOT_FOUND response instead. Requires `session === undefined`,
+  // not just a lease-less session: a *stored* session under tenant isolation
+  // is keyed by tenant, not by run, so a lease-less stored session could
+  // belong to another run in the same tenant — admission must still verify a
+  // matching lease before that run's session can be torn down. Which request
+  // shape qualifies (plain `close`, not an app-target `close <app>`) is the
+  // registry's call, not this module's — see `sessionlessPlainCloseAdmissionExempt`.
   if (
     session === undefined &&
     !requestLeaseScope.leaseId &&
-    req.command === 'close' &&
-    (req.positionals?.length ?? 0) === 0
+    isSessionlessPlainCloseAdmissionExempt(req)
   ) {
     return undefined;
   }