test(ios): extract snapshot truncation regressions

Author: thymikee

src/__tests__/client-snapshot-truncation.test.ts

@@ -0,0 +1,20 @@
+import assert from 'node:assert/strict';
+import { test } from 'vitest';
+import { createAgentDeviceClient } from '../agent-device-client.ts';
+import { createTransport } from './client-transport-fixture.ts';
+
+test('client capture.snapshot preserves unknown truncation as an omitted field', async () => {
+  const setup = createTransport(async () => ({
+    ok: true,
+    data: {
+      nodes: [],
+      warnings: ['tree completeness is not independently verified'],
+    },
+  }));
+  const client = createAgentDeviceClient(setup.config, { transport: setup.transport });
+
+  const result = await client.capture.snapshot();
+
+  assert.equal('truncated' in result, false);
+  assert.equal(result.truncated, undefined);
+});

src/__tests__/client-transport-fixture.ts

@@ -0,0 +1,36 @@
+import type { AgentDeviceClientConfig } from '../agent-device-client.ts';
+import type { DaemonRequest, DaemonResponse } from '@agent-device/kernel/contracts';
+import { mkdtempForTestSync } from './test-utils/tmp-dir.ts';
+
+const TEST_STATE_DIR = mkdtempForTestSync('agent-device-client-test-');
+
+export function createTransport(
+  handler: (req: Omit<DaemonRequest, 'token'>) => Promise<DaemonResponse> | DaemonResponse,
+): {
+  calls: Array<Omit<DaemonRequest, 'token'>>;
+  config: AgentDeviceClientConfig;
+  transport: (req: Omit<DaemonRequest, 'token'>) => Promise<DaemonResponse>;
+} {
+  const calls: Array<Omit<DaemonRequest, 'token'>> = [];
+  const config: AgentDeviceClientConfig = {
+    session: 'qa',
+    stateDir: TEST_STATE_DIR,
+    cwd: '/tmp/agent-device',
+    debug: true,
+    daemonBaseUrl: 'http://daemon.example.test',
+    daemonAuthToken: 'secret',
+    daemonTransport: 'http',
+    tenant: 'acme',
+    sessionIsolation: 'tenant',
+    runId: 'run-123',
+    leaseId: 'lease-123',
+  };
+  return {
+    calls,
+    config,
+    transport: async (req) => {
+      calls.push(req);
+      return await handler(req);
+    },
+  };
+}

src/__tests__/client.test.ts

@@ -10,7 +10,6 @@ import type {
 import {
   createAgentDeviceClient,
   type AgentDeviceClient,
-  type AgentDeviceClientConfig,
   type DiffSnapshotCommandResult,
   type DoctorCommandResult,
   type PrepareCommandResult,
@@ -24,18 +23,12 @@ import {
 } from '../agent-device-client.ts';
 import { runCommand } from '../commands/command-surface.ts';
 import type { CommandResult } from '../core/command-descriptor/command-result.ts';
-import type {
-  DaemonRequest,
-  DaemonResponse,
-  DaemonResponseData,
-} from '@agent-device/kernel/contracts';
+import type { DaemonResponse, DaemonResponseData } from '@agent-device/kernel/contracts';
 import { AppError } from '@agent-device/kernel/errors';
 import fs from 'node:fs';
 import nodePath from 'node:path';
 import { mkdtempForTestSync } from './test-utils/tmp-dir.ts';
-
-// Isolated so open/close metro-session-hint file writes never touch the real state dir.
-const TEST_STATE_DIR = mkdtempForTestSync('agent-device-client-test-');
+import { createTransport } from './client-transport-fixture.ts';
 
 // #1802: replay/test requests carry the script text the CLIENT read, so these cases need real
 // files. `cwd` is what the writer resolves the caller's relative path against.
@@ -96,37 +89,6 @@ const closedProjectionResponses: Record<string, DaemonResponseData> = {
   },
 };
 
-function createTransport(
-  handler: (req: Omit<DaemonRequest, 'token'>) => Promise<DaemonResponse> | DaemonResponse,
-): {
-  calls: Array<Omit<DaemonRequest, 'token'>>;
-  config: AgentDeviceClientConfig;
-  transport: (req: Omit<DaemonRequest, 'token'>) => Promise<DaemonResponse>;
-} {
-  const calls: Array<Omit<DaemonRequest, 'token'>> = [];
-  const config: AgentDeviceClientConfig = {
-    session: 'qa',
-    stateDir: TEST_STATE_DIR,
-    cwd: '/tmp/agent-device',
-    debug: true,
-    daemonBaseUrl: 'http://daemon.example.test',
-    daemonAuthToken: 'secret',
-    daemonTransport: 'http',
-    tenant: 'acme',
-    sessionIsolation: 'tenant',
-    runId: 'run-123',
-    leaseId: 'lease-123',
-  };
-  return {
-    calls,
-    config,
-    transport: async (req) => {
-      calls.push(req);
-      return await handler(req);
-    },
-  };
-}
-
 test('client exposes narrowed result types for closed daemon projections', async () => {
   const setup = createTransport(async (req) => closedProjectionResponse(req.command));
   const client = createAgentDeviceClient(setup.config, { transport: setup.transport });
@@ -1118,22 +1080,6 @@ test('client capture.snapshot preserves visibility metadata from daemon response
   });
 });
 
-test('client capture.snapshot preserves unknown truncation as an omitted field', async () => {
-  const setup = createTransport(async () => ({
-    ok: true,
-    data: {
-      nodes: [],
-      warnings: ['tree completeness is not independently verified'],
-    },
-  }));
-  const client = createAgentDeviceClient(setup.config, { transport: setup.transport });
-
-  const result = await client.capture.snapshot();
-
-  assert.equal('truncated' in result, false);
-  assert.equal(result.truncated, undefined);
-});
-
 test('client capture.snapshot preserves refsGeneration from daemon responses (ADR 0014)', async () => {
   const setup = createTransport(async () => ({
     ok: true,

src/daemon/handlers/__tests__/snapshot-handler-fixture.ts

@@ -0,0 +1,32 @@
+import path from 'node:path';
+import { mkdtempForTestSync } from '../../../__tests__/test-utils/tmp-dir.ts';
+import type { ProviderDeviceRuntime } from '@agent-device/contracts/device';
+import { SessionStore } from '../../session-store.ts';
+import type { SessionState } from '../../types.ts';
+
+export function makeSessionStore(): SessionStore {
+  const root = mkdtempForTestSync('agent-device-snapshot-handler-');
+  return new SessionStore(path.join(root, 'sessions'));
+}
+
+export function makeSession(
+  name: string,
+  device: SessionState['device'],
+  extra?: Partial<SessionState>,
+): SessionState {
+  return { name, device, createdAt: Date.now(), actions: [], ...extra };
+}
+
+export function makeProviderRuntimeOwning(
+  device: SessionState['device'],
+  provider = 'browserstack',
+): ProviderDeviceRuntime {
+  return {
+    provider,
+    leaseLifecycle: {},
+    deviceInventoryProvider: async () => [device],
+    ownsDevice: (candidate) => candidate.id === device.id,
+    getInteractor: () => undefined,
+    shutdown: async () => undefined,
+  };
+}

src/daemon/handlers/__tests__/snapshot-handler.test.ts

@@ -6,29 +6,30 @@ import {
   resetGetRuntimeFixture,
 } from './interaction-get-runtime-fixture.ts';
 import fs from 'node:fs';
-import path from 'node:path';
 import { handleSnapshotCommands as handleProductionSnapshotCommands } from '../snapshot.ts';
 import { captureSnapshot } from '../snapshot-capture.ts';
 import { SessionStore } from '../../session-store.ts';
 import { setActiveProviderDeviceRuntimes } from '../../../provider-device-runtime.ts';
-import type { ProviderDeviceRuntime } from '@agent-device/contracts/device';
 import type { DaemonResponse, SessionState } from '../../types.ts';
 import { AppError } from '@agent-device/kernel/errors';
 import { platformResourceCleanup } from '../../../platform-runtime-resource-cleanup.ts';
 import { buildSnapshotSignatures } from '../../../snapshot/snapshot-freshness/index.ts';
 import { buildInteractionSurfaceSignature } from '../../interaction-outcome-policy.ts';
 import { buildSnapshotPresentationKey } from '@agent-device/kernel/snapshot';
-import { attachSnapshotPresentationEvidence } from '@agent-device/contracts/capture';
 import { snapshotCliOutput } from '../../../commands/capture/output.ts';
 import type { CaptureSnapshotResult } from '@agent-device/contracts/client';
-import { mkdtempForTestSync } from '../../../__tests__/test-utils/tmp-dir.ts';
 import {
   fixtureScreenshotCaptures,
   fixtureSettingsMutations,
   resetSnapshotRuntimeFixture,
   snapshotRuntimeFixture,
 } from '../../__tests__/snapshot-runtime-fixture.ts';
 import type { BindDeviceRuntime } from '../../request-runtime-binding.ts';
+import {
+  makeProviderRuntimeOwning,
+  makeSession,
+  makeSessionStore,
+} from './snapshot-handler-fixture.ts';
 
 vi.mock('../snapshot-interactor-capture.ts', async () => {
   const fixture = await import('../../__tests__/legacy-snapshot-capture-fixture.ts');
@@ -75,15 +76,6 @@ function handleSnapshotCommands(
   });
 }
 
-function makeSessionStore(): SessionStore {
-  const root = mkdtempForTestSync('agent-device-snapshot-handler-');
-  return new SessionStore(path.join(root, 'sessions'));
-}
-
-type SessionExtra = Partial<SessionState>;
-function makeSession(name: string, d: SessionState['device'], extra?: SessionExtra): SessionState {
-  return { name, device: d, createdAt: Date.now(), actions: [], ...extra };
-}
 // An Apple wait runs inside an opened app: that bundle id is XCUITest's attach target, and
 // without one the plan asks for the without-active-app row local Apple refuses.
 const appAttach = (d: SessionState['device']): Partial<SessionState> =>
@@ -125,20 +117,6 @@ const providerIosDevice: SessionState['device'] = {
   booted: true,
 };
 
-function makeProviderRuntimeOwning(
-  device: SessionState['device'],
-  provider = 'browserstack',
-): ProviderDeviceRuntime {
-  return {
-    provider,
-    leaseLifecycle: {},
-    deviceInventoryProvider: async () => [device],
-    ownsDevice: (candidate) => candidate.id === device.id,
-    getInteractor: () => undefined,
-    shutdown: async () => undefined,
-  };
-}
-
 afterEach(() => {
   setActiveProviderDeviceRuntimes([]);
 });
@@ -488,55 +466,6 @@ test('snapshot on provider-backed iOS runs without a tracked app', async () => {
   expect(bindCount).toBe(1);
 });
 
-test('Limrun unknown truncation stays omitted through daemon and public output', async () => {
-  const sessionStore = makeSessionStore();
-  const sessionName = 'limrun-ios-unknown-truncation';
-  const limrunDevice: SessionState['device'] = {
-    platform: 'apple',
-    appleOs: 'ios',
-    id: 'limrun:ios:lease-a',
-    name: 'Limrun iOS',
-    kind: 'simulator',
-    target: 'mobile',
-    booted: true,
-  };
-  sessionStore.set(sessionName, makeSession(sessionName, limrunDevice));
-  setActiveProviderDeviceRuntimes([makeProviderRuntimeOwning(limrunDevice, 'limrun')]);
-  legacyDispatchCapture.mockResolvedValue(
-    attachSnapshotPresentationEvidence(
-      {
-        nodes: [{ index: 0, depth: 0, type: 'Application', label: 'Demo' }],
-        backend: 'xctest',
-        producer: 'limrun-ios-tree',
-        warnings: ['tree completeness is not independently verified'],
-      },
-      { owner: 'ios-snapshot-engine' },
-    ),
-  );
-
-  const response = await handleSnapshotCommands({
-    req: {
-      token: 't',
-      session: sessionName,
-      command: 'snapshot',
-      positionals: [],
-      flags: {},
-    },
-    sessionName,
-    logPath: '/tmp/daemon.log',
-    sessionStore,
-  });
-
-  expect(response?.ok).toBe(true);
-  if (!response?.ok) return;
-  expect(response.data).not.toHaveProperty('truncated');
-
-  const cliOutput = await snapshotCliOutput({
-    result: response.data as unknown as CaptureSnapshotResult,
-  });
-  expect(cliOutput.jsonData).not.toHaveProperty('truncated');
-});
-
 test('diff on local iOS still requires a tracked app', async () => {
   const sessionStore = makeSessionStore();
   const sessionName = 'ios-sim-no-app-diff';