fix(replay): preserve deep-link target resolution

Author: thymikee

src/daemon/__tests__/replay-device-selection.test.ts

@@ -0,0 +1,21 @@
+import { test, expect } from 'vitest';
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+import { buildReplayTargetDeviceResolutionOptions } from '../replay-device-selection.ts';
+
+test('replay leaves deep-link opens to normal device resolution', () => {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), 'agent-device-replay-device-selection-'));
+  const replayPath = path.join(root, 'deep-link.ad');
+  fs.writeFileSync(replayPath, 'open demo://checkout\n');
+
+  expect(
+    buildReplayTargetDeviceResolutionOptions({
+      token: 'test-token',
+      session: 'default',
+      command: 'replay',
+      positionals: [replayPath],
+      meta: { cwd: root },
+    }),
+  ).toBeUndefined();
+});

src/daemon/open-device-selection.ts

@@ -5,6 +5,12 @@ export function buildOpenTargetDeviceResolutionOptions(
   openTarget: string | undefined,
 ): ResolveTargetDeviceOptions {
   return {
-    appleSimulatorAppTarget: openTarget && !isDeepLinkTarget(openTarget) ? openTarget : undefined,
+    appleSimulatorAppTarget: appleSimulatorAppTargetForOpenTarget(openTarget),
   };
 }
+
+export function appleSimulatorAppTargetForOpenTarget(
+  openTarget: string | undefined,
+): string | undefined {
+  return openTarget && !isDeepLinkTarget(openTarget) ? openTarget : undefined;
+}

src/daemon/replay-device-selection.ts

@@ -3,6 +3,7 @@ import { parseReplayInput } from '../compat/replay-input.ts';
 import { parseMaestroProgram } from '../compat/maestro/program-ir-parser.ts';
 import type { ResolveTargetDeviceOptions } from '../core/dispatch-resolve.ts';
 import type { MaestroProgram } from '../compat/maestro/program-ir.ts';
+import { appleSimulatorAppTargetForOpenTarget } from './open-device-selection.ts';
 import { SessionStore } from './session-store.ts';
 import type { DaemonRequest, SessionAction } from './types.ts';
 
@@ -23,7 +24,7 @@ export function buildReplayTargetDeviceResolutionOptions(
     const appTarget = isMaestroReplay(req, resolved)
       ? readMaestroReplayAppTarget(parseMaestroProgram(source, { sourcePath: resolved }))
       : readScriptReplayAppTarget(parseReplayInput(source, req.flags).actions);
-    return appTarget ? { appleSimulatorAppTarget: appTarget } : undefined;
+    return appTargetResolutionOptions(appTarget);
   } catch {
     // Parsing and validation stay in the replay handler. Lock binding is only
     // advisory, so an unreadable/invalid plan must not mask its real error.
@@ -35,7 +36,7 @@ export function buildMaestroReplayTargetDeviceResolutionOptions(
   program: MaestroProgram,
 ): ResolveTargetDeviceOptions {
   const appTarget = readMaestroReplayAppTarget(program);
-  return appTarget ? { appleSimulatorAppTarget: appTarget } : {};
+  return appTargetResolutionOptions(appTarget) ?? {};
 }
 
 function isMaestroReplay(req: DaemonRequest, filePath: string): boolean {
@@ -62,3 +63,10 @@ function readMaestroReplayAppTarget(program: MaestroProgram): string | undefined
 function isStaticAppTarget(value: string | undefined): value is string {
   return Boolean(value && value.trim() && !value.includes('$'));
 }
+
+function appTargetResolutionOptions(
+  openTarget: string | undefined,
+): ResolveTargetDeviceOptions | undefined {
+  const appTarget = appleSimulatorAppTargetForOpenTarget(openTarget);
+  return appTarget ? { appleSimulatorAppTarget: appTarget } : undefined;
+}