Skip to content

Commit 6154523

Browse files
committed
test(vitest): record the subprocess-stub kill-criterion outcome
#1823's kill criterion was met (~64 consecutive genuine Coverage-job completions since dbc4f2f with zero timeout-shaped failures), so the subprocess-stub project is gone for good rather than mid-experiment. Rewrite the vitest.config.ts comments to state that resolved outcome instead of framing it as an ongoing revert-on-first-failure trial.
1 parent 8021503 commit 6154523

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

vitest.config.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,12 @@ import slowTestGateReporter from './scripts/vitest-slow-test-reporter.ts';
44

55
// Files that spawn a real subprocess per case. They used to run one at a time in
66
// their own serialized `subprocess-stub` project so broad file parallelism couldn't
7-
// starve a spawn past its internal budget and turn it into a generic timeout.
8-
// #1823 is now running that project's own kill criterion: un-serialized here in
9-
// `unit-core`'s default forks pool, watched for 20 consecutive CI runs with no
10-
// timeout-shaped failure. Revert (restore the project, restore this list to
11-
// unit-core's exclude) the moment one appears. Still excluded from the mutation
12-
// lane via SERIALIZED_TESTS below regardless of this experiment's outcome —
13-
// thousands of mutant reruns times a real spawn per case is timeout noise either way.
7+
// starve a spawn past its internal budget and turn it into a generic timeout. #1823's
8+
// kill criterion — 20 consecutive CI runs un-serialized in `unit-core`'s default forks
9+
// pool with no timeout-shaped failure — was met, so the project is gone and these
10+
// files run un-serialized here. The list still feeds SERIALIZED_TESTS below: a real
11+
// per-case spawn is timeout noise under thousands of mutant reruns regardless of
12+
// Vitest's own scheduling, so the mutation lane keeps excluding them.
1413
const SUBPROCESS_STUB_TESTS: readonly string[] = [
1514
// Stubs npx plus the package managers and spawns a real Metro dev server per case.
1615
'src/__tests__/client-metro.test.ts',
@@ -106,8 +105,8 @@ export default defineConfig({
106105
'src/**/*.test.ts',
107106
'packages/*/src/**/*.test.ts',
108107
// The subprocess watchdog self-check (#1823): spawns a real node subprocess per
109-
// case, one hangs on purpose (#1414). Formerly a `subprocess-stub` member; see
110-
// SUBPROCESS_STUB_TESTS above for the kill-criterion experiment this rides.
108+
// case, one hangs on purpose (#1414). Formerly a `subprocess-stub` member,
109+
// deleted once its kill criterion was met; see SUBPROCESS_STUB_TESTS above.
111110
'scripts/fuzz/harness.test.ts',
112111
// The validation fuzz generators' expectation gates (#1781 B2): in-process, no
113112
// subprocess or worker, so they ride the fast lane unlike their serialized siblings.

0 commit comments

Comments
 (0)