Skip to content

Commit 60a3f0e

Browse files
committed
fix: address absence assertion review feedback
1 parent 7973fb8 commit 60a3f0e

17 files changed

Lines changed: 816 additions & 675 deletions

File tree

packages/ad-script/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export {
2121
export {
2222
parseTargetAnnotationV1Payload,
2323
serializeTargetAnnotationV1,
24+
truncateToUtf8Bytes,
2425
utf8ByteLength,
2526
TARGET_ANNOTATION_MAX_ANCESTRY,
2627
TARGET_ANNOTATION_MAX_FIELD_BYTES,

scripts/__tests__/eager-closure-budgets.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export function discoverFacadeEntryFiles(repoRoot: string): string[] {
106106
*/
107107
export const FACADE_BUDGETS: Readonly<Record<string, number>> = Object.freeze({
108108
// --- @agent-device/ad-replay ---
109-
'packages/ad-replay/src/index.ts': 61,
109+
'packages/ad-replay/src/index.ts': 62,
110110

111111
// --- @agent-device/ad-script ---
112112
'packages/ad-script/src/index.ts': 41,
@@ -233,6 +233,7 @@ export const FACADE_BUDGETS: Readonly<Record<string, number>> = Object.freeze({
233233
'packages/contracts/src/interactor-types.ts': 1,
234234
// #2190's iOS snapshot vocabulary has type-only imports and remains a one-module entry.
235235
'packages/contracts/src/ios-snapshot.ts': 1,
236+
'packages/contracts/src/is-predicate.ts': 1,
236237
'packages/contracts/src/keyboard.ts': 1,
237238
'packages/contracts/src/logs-runtime-plan.ts': 5,
238239
'packages/contracts/src/managed-web-backend.ts': 1,
@@ -300,7 +301,7 @@ export const FACADE_BUDGETS: Readonly<Record<string, number>> = Object.freeze({
300301
'packages/kernel/src/snapshot.ts': 1,
301302

302303
// --- @agent-device/maestro ---
303-
'packages/maestro/src/index.ts': 110,
304+
'packages/maestro/src/index.ts': 111,
304305

305306
// --- @agent-device/platform-*: ADR-0019's metadata-eager/implementation-lazy façades. Each
306307
// evaluates only itself; every implementation sits behind a function-scoped `await import`.
@@ -351,7 +352,7 @@ export const FACADE_BUDGETS: Readonly<Record<string, number>> = Object.freeze({
351352
// --- @agent-device/selectors ---
352353
'packages/selectors/src/ast.ts': 16,
353354
'packages/selectors/src/engine.ts': 19,
354-
'packages/selectors/src/index.ts': 54,
355+
'packages/selectors/src/index.ts': 55,
355356

356357
// --- @agent-device/xml ---
357358
'packages/xml/src/index.ts': 3,
@@ -410,9 +411,9 @@ export const HUB_BUDGETS: Readonly<Record<string, number>> = Object.freeze({
410411
// #2148 moves output-only CLI dependencies behind call-time imports and reduces the entry
411412
// closure by two modules.
412413
// #2146 splits one eagerly reached URL utility into its client and Metro owners.
413-
'src/cli.ts': 379,
414+
'src/cli.ts': 380,
414415
'src/platform-runtime.ts': 47,
415-
'src/core/command-descriptor/registry.ts': 71,
416+
'src/core/command-descriptor/registry.ts': 72,
416417
'src/core/command-descriptor/platform-execution-entry.ts': 3,
417418
'src/core/interactors/register-builtins.ts': 6,
418419
// R64 removes the perf plugin facet and keeps collector binding behind the selected runtime

src/__tests__/is-argument-surface-parity.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import type { CliFlags } from '@agent-device/contracts/command';
1818
// Three surfaces validate the same rule: the daemon handler (via `checkIsArgs`), the CLI
1919
// grammar (`readInputFromCli`), and the runtime command that receives already-parsed
2020
// options (`isCommand`, covered on its own production route in
21-
// commands/interaction/runtime/selector-read.test.ts). They used to state the rule three
21+
// commands/interaction/runtime/selector-is.test.ts). They used to state the rule three
2222
// times, and all three had drifted: one inlined its own predicate list, one compared the raw
2323
// token so it rejected input the daemon accepts, and one dropped the usage hint.
2424
//

src/commands/interaction/runtime/index.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ import {
2828
getAttrsCommand,
2929
getCommand,
3030
getTextCommand,
31-
isCommand,
32-
isHiddenCommand,
33-
isVisibleCommand,
3431
waitCommand,
3532
waitForTextCommand,
3633
type ElementTarget,
@@ -40,21 +37,25 @@ import {
4037
type GetCommandOptions,
4138
type GetCommandResult,
4239
type GetTextCommandOptions,
43-
type IsCommandOptions,
44-
type IsCommandResult,
45-
type IsSelectorCommandOptions,
46-
type SelectorTarget,
4740
type WaitCommandOptions,
4841
type WaitCommandResult,
4942
type WaitForTextCommandOptions,
5043
} from './selector-read.ts';
44+
import {
45+
isCommand,
46+
isHiddenCommand,
47+
isVisibleCommand,
48+
type IsCommandOptions,
49+
type IsCommandResult,
50+
type IsSelectorCommandOptions,
51+
} from './selector-is.ts';
5152
import {
5253
gestureCommand,
5354
type GestureCommandOptions,
5455
type GestureCommandResult,
5556
} from './gesture-command.ts';
5657
import { settleObservationCommand, type SettleObservationCommandOptions } from './settle.ts';
57-
import type { SettleObservation } from '@agent-device/contracts/interaction';
58+
import type { SelectorTarget, SettleObservation } from '@agent-device/contracts/interaction';
5859

5960
export type SelectorCommands = {
6061
find: RuntimeCommand<FindReadCommandOptions, FindReadCommandResult>;

0 commit comments

Comments
 (0)