Merge remote-tracking branch 'origin/codex/2189-ios-snapshot-baselines' into codex/2189-ios-snapshot-baselines

* origin/codex/2189-ios-snapshot-baselines: (27 commits)
  fix: move mutation ownership to snapshot module
  test: verify preserved size reporter closure
  test: pin shared publish asset owner
  fix: retire stale utils layering zone
  test(size): update publish preparation contracts
  style(size): format package evidence test
  fix(size): make publish asset evidence hermetic
  docs(ios): republish exact-head benchmark corpus
  fix(ios-benchmark): admit proxy fixture anchors
  chore(ios): format benchmark evidence
  docs(ios): publish snapshot convergence corpus
  test(ios): admit native alert snapshots
  test(ios): reset alert between relaunch samples
  test(ios): reveal offscreen alert fixture controls
  docs(ios-benchmark): retain exact-head evidence
  fix(ios-benchmark): preserve async timeout evidence
  fix(ios-benchmark): keep fresh proxy CLI sessions isolated
  fix(ios-benchmark): bind proxy lease to simulator
  fix(ios-benchmark): parse proxy startup envelope
  test(ios-benchmark): keep CLI process seam local
  ...

# Conflicts:
#	vitest.config.ts

Author: thymikee

scripts/__tests__/prepare-publish-assets.test.ts

@@ -0,0 +1,47 @@
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import { test } from 'vitest';
+import { mkdtempForTestSync } from '../../src/__tests__/test-utils/tmp-dir.ts';
+import { preparePublishAssets } from '../prepare-publish-assets.mjs';
+
+test('prepares both Android runtime helpers through the shared publish owner', () => {
+  const root = mkdtempForTestSync('agent-device-publish-assets-');
+  const scriptsDirectory = path.join(root, 'scripts');
+  fs.mkdirSync(scriptsDirectory, { recursive: true });
+  fs.writeFileSync(path.join(root, 'package.json'), '{"version":"1.2.3"}\n');
+  fs.writeFileSync(path.join(scriptsDirectory, 'package-apple-runner-source.mjs'), '');
+  fs.writeFileSync(
+    path.join(scriptsDirectory, 'package-android-helper.sh'),
+    `#!/bin/sh
+set -eu
+if [ "$AGENT_DEVICE_ANDROID_HELPER" = "snapshot" ]; then
+  output="$3"
+else
+  output="$2"
+fi
+mkdir -p "$output"
+prefix="agent-device-android-$AGENT_DEVICE_ANDROID_HELPER-helper-$1"
+printf apk > "$output/$prefix.apk"
+printf manifest > "$output/$prefix.manifest.json"
+printf checksum > "$output/$prefix.apk.sha256"
+`,
+  );
+
+  const stalePath = path.join(root, 'android', 'ime-helper', 'dist', 'stale.apk');
+  fs.mkdirSync(path.dirname(stalePath), { recursive: true });
+  fs.writeFileSync(stalePath, 'stale');
+
+  preparePublishAssets({ root });
+
+  assert.equal(fs.existsSync(stalePath), false);
+  for (const helper of ['snapshot', 'ime']) {
+    const prefix = `agent-device-android-${helper}-helper-1.2.3`;
+    const directory = path.join(root, 'android', `${helper}-helper`, 'dist');
+    assert.deepEqual(fs.readdirSync(directory).sort(), [
+      `${prefix}.apk`,
+      `${prefix}.apk.sha256`,
+      `${prefix}.manifest.json`,
+    ]);
+  }
+});

scripts/__tests__/size-report-package.test.ts

@@ -102,7 +102,7 @@ test('Markdown reports component diffs and changed packed files', () => {
     js: { rawBytes: 10, gzipBytes: 8 },
     npmPack: {
       tarballBytes: 100,
-      unpackedBytes: 1713,
+      unpackedBytes: 2218,
       components: summarizeNpmPackComponents({
         ...fixturePack,
         unpackedSize: 2218,

scripts/layering/model.test.ts

@@ -249,7 +249,7 @@ test('classifyZone separates the ranked spine from intentionally-unranked zones'
   assert.equal(classifyZone('(root)'), 'unranked');
   assert.equal(classifyZone('platform-runtime'), 'unranked');
   assert.equal(classifyZone('platforms'), 'unclassified');
-  assert.equal(classifyZone('utils'), 'ranked');
+  assert.equal(classifyZone('utils'), 'unclassified');
   // Every satellite zone joined the spine; only the composition root stays out, because R2
   // forbids daemon/ from importing commands/ so the files that wire them cannot be ranked.
   assert.equal(classifyZone('mcp'), 'ranked');

scripts/layering/model.ts

@@ -46,7 +46,6 @@ const TARGET_DAG_RANK = new Map([
   ['screenshot-diff', 1],
   ['selectors', 1],
   ['snapshot', 1],
-  ['utils', 1],
   ['core', 2],
   ['cli-schema', 3],
   ['commands', 3],
@@ -78,9 +77,9 @@ export function zoneRank(zone: string): number | null {
 // and the no-root-back-import rule instead of their former src folder rank.
 //
 // The satellite zones used to be listed here too, on the grounds that ranking them would
-// invent an order the architecture had not committed to. Once `utils` joined the spine and
-// `(root)` was emptied of shared contracts, every one of them turned out to have a
-// consistent rank already — so the order was there, just unasserted.
+// invent an order the architecture had not committed to. Once `(root)` was emptied of shared
+// contracts, every one of them turned out to have a consistent rank already — so the order was
+// there, just unasserted. The former `utils` zone was retired into owning modules and packages.
 // Extracted workspace packages are not src/ zones: R11 owns their physical seams, and their zone
 // names only appear in workspace-aware graphs. The platform packages additionally carry R13's
 // exact-family/composition/laziness policy.

scripts/mutation/modules.ts

@@ -61,8 +61,8 @@ export const KERNEL_MODULES: readonly KernelModule[] = [
   {
     id: 'scroll-edge-state',
     label: 'Scroll edge-state detection',
-    mutate: ['src/utils/scroll-edge-state.ts'],
-    owns: ['src/utils/scroll-edge-state.ts'],
+    mutate: ['src/snapshot/scroll-edge-state.ts', 'src/snapshot/scroll-edge-state/**/*.ts'],
+    owns: ['src/snapshot/scroll-edge-state.ts', 'src/snapshot/scroll-edge-state/'],
   },
   {
     id: 'selectors',

scripts/mutation/selection.test.ts

@@ -80,9 +80,9 @@ test('a lane-tooling diff selects real mutants', () => {
 // The weekly sweep is the kernel report; selecting on derived ownership would
 // run the full ten-shard sweep on most PRs for a report nobody gates on.
 test('a kernel diff selects nothing — only a harness diff spends mutants', () => {
-  const dir = worktreeWithCommit('kernel', ['src/utils/scroll-edge-state.ts']);
+  const dir = worktreeWithCommit('kernel', ['src/snapshot/scroll-edge-state.ts']);
   assert.deepEqual(listAffected(dir), []);
-  assert.deepEqual(affectedMatrixFor(['src/utils/scroll-edge-state.ts']), []);
+  assert.deepEqual(affectedMatrixFor(['src/snapshot/scroll-edge-state.ts']), []);
 });
 
 test('a docs-only diff selects nothing', () => {

src/__tests__/npm-package-scripts.test.ts

@@ -61,6 +61,7 @@ test('the npm package build covers every package-owned output before verificatio
     'pnpm build:macos-helper:clean',
     'pnpm prepare:publish-assets',
   ]);
+  assert.equal(script('prepare:publish-assets'), 'node scripts/prepare-publish-assets.mjs');
   assert.equal(script('package:npm'), 'pnpm build:package && pnpm check:package');
 
   assert.deepEqual(script('build:android').split(' && '), [

stryker.config.json

@@ -34,7 +34,8 @@
     "packages/kernel/src/errors.ts",
     "src/daemon/ref-frame.ts",
     "src/commands/interaction/runtime/settle.ts",
-    "src/utils/scroll-edge-state.ts",
+    "src/snapshot/scroll-edge-state.ts",
+    "src/snapshot/scroll-edge-state/**/*.ts",
     "packages/selectors/src/**/*.ts",
     "!packages/selectors/src/**/*.test.ts",
     "!packages/selectors/src/internal/__tests__/**",

test/ci/size-workflow.test.ts

@@ -27,16 +27,20 @@ test('the preserved size reporter keeps its entrypoint and relative modules toge
   const measureBase = workflowStep('Measure base size').run ?? '';
 
   expect(preserve).toContain(`mkdir -p ${preservedReportDir}`);
-  expect(preserve).toContain(`cp scripts/size-report*.mjs ${preservedReportDir}/`);
+  expect(preserve).toContain('cp scripts/size-report*.mjs');
   expect(measureBase).toContain(`node ${preservedReportDir}/size-report.mjs`);
 
   const reportSource = fs.readFileSync(path.join(repoRoot, 'scripts/size-report.mjs'), 'utf8');
-  const relativeModules = [...reportSource.matchAll(/from '\.\/(size-report-[^']+\.mjs)'/g)].map(
+  const relativeModules = [...reportSource.matchAll(/from '\.\/([^']+\.mjs)'/g)].map(
     (match) => match[1],
   );
   expect(relativeModules.length).toBeGreaterThan(0);
   for (const moduleName of relativeModules) {
     if (!moduleName) throw new Error('relative size-report import has no module name');
     expect(fs.existsSync(path.join(repoRoot, 'scripts', moduleName)), moduleName).toBe(true);
+    expect(
+      moduleName.startsWith('size-report-') || preserve.includes(`scripts/${moduleName}`),
+      `${moduleName} must be preserved for the base checkout`,
+    ).toBe(true);
   }
 });

vitest.config.ts

@@ -150,6 +150,9 @@ export default defineConfig({
             // Package attribution models npm-pack output. Keep it in the fast lane so every new
             // package path remains accounted for.
             'scripts/__tests__/size-report-package.test.ts',
+            // Publish preparation spawns only fixture-owned scripts and proves both Android
+            // helper families are rebuilt through the shared release/size-report owner.
+            'scripts/__tests__/prepare-publish-assets.test.ts',
             'scripts/ios-snapshot-benchmark/*.test.ts',
             // Parses CI configuration only, so this action guard needs no device or subprocess lane.
             'test/ci/upload-agent-device-artifacts.test.ts',