test(daemon): assert the retained session's in-memory close action, not just the durable event

Review feedback on #1392 (thymikee): the durable-event assertion alone
doesn't catch a reintroduced session.actions.length = actionsBeforeClose
rollback, because that event is queued (and durable) before the write
even attempts — a regression there would leave the assertion passing
while silently reintroducing the in-memory/durable mismatch.

Retain the session object past handleCloseCommand (store.delete only
drops the map entry, not the object a local variable still points at)
and assert its actions array contains exactly one close entry, matching
the durable event count. Verified by temporarily reintroducing the old
rollback locally: this assertion fails (0 !== 1) where the prior
durable-only check did not, then reverted.

Author: thymikee

src/daemon/handlers/__tests__/session-device-claims.test.ts

@@ -35,6 +35,7 @@ import { SessionStore } from '../../session-store.ts';
 import { handleCloseCommand } from '../session-close.ts';
 import { handleOpenCommand } from '../session-open.ts';
 import type { DeviceInfo } from '../../../kernel/device.ts';
+import type { SessionState } from '../../types.ts';
 import { AppError } from '../../../kernel/errors.ts';
 
 const mockDispatch = vi.mocked(dispatchCommand);
@@ -258,15 +259,20 @@ test('#1391: a close-time script save failure still clears the advisory claim an
   assert.ok(acquired.ownership);
   const targetPath = path.join(stateDir, 'already-published.ad');
   fs.writeFileSync(targetPath, 'pre-existing\n');
-  store.set('close-save-script-failure', {
+  // Retained directly (not just looked up via `store`) so it stays inspectable
+  // after `handleCloseCommand` deletes it from the store — `store.delete` only
+  // drops the map entry, it doesn't touch the object this variable still
+  // points at.
+  const session: SessionState = {
     name: 'close-save-script-failure',
     device: android,
     deviceClaim: acquired.ownership,
     createdAt: Date.now(),
     actions: [],
     recordSession: true,
     saveScriptPath: targetPath,
-  });
+  };
+  store.set('close-save-script-failure', session);
   mockDispatch.mockResolvedValue({});
 
   // Like the platform-close-error tests above, a failed close-time save is
@@ -323,4 +329,15 @@ test('#1391: a close-time script save failure still clears the advisory claim an
     closeEvent,
     'expected a durable action.recorded:close event to survive the failed save',
   );
+  // Same assertion, in-memory: reinstating `session.actions.length =
+  // actionsBeforeClose` would still pass the durable-event check above (that
+  // event was already queued before the write failed) while silently
+  // dropping this to zero — assert directly on the retained session object,
+  // not just the store, so that specific regression is caught.
+  const inMemoryCloseActions = session.actions.filter((action) => action.command === 'close');
+  assert.equal(inMemoryCloseActions.length, 1);
+  assert.equal(
+    inMemoryCloseActions.length,
+    events.filter((event) => event.command === 'close').length,
+  );
 });