refactor(daemon): move open lifecycle behind session facade (#2201)

Author: thymikee

fallow-baselines/health.json

@@ -199,7 +199,7 @@
         "count": 1
       }
     },
-    "src/daemon/handlers/__tests__/session-open-runtime.test.ts": {
+    "src/daemon/session-lifecycle/internal/__tests__/session-open-runtime.test.ts": {
       "crap_moderate": {
         "count": 1
       }
@@ -240,12 +240,12 @@
         "count": 2
       }
     },
-    "src/daemon/handlers/session-open-surface.ts": {
+    "src/daemon/session-lifecycle/internal/session-open-surface.ts": {
       "crap_moderate": {
         "count": 1
       }
     },
-    "src/daemon/handlers/session-open.ts": {
+    "src/daemon/session-lifecycle/internal/session-open.ts": {
       "crap_moderate": {
         "count": 1
       }
@@ -255,7 +255,7 @@
         "count": 1
       }
     },
-    "src/daemon/handlers/session-runtime.ts": {
+    "src/daemon/session-runtime.ts": {
       "crap_moderate": {
         "count": 1
       }

scripts/__tests__/help-conformance-sample-producers.ts

@@ -21,7 +21,7 @@ import { openCliOutput } from '../../src/commands/management/output.ts';
 import { NEVER_SETTLED_HINT } from '../../src/commands/interaction/runtime/settle.ts';
 import { buildAmbiguousMatchError } from '../../src/daemon/handlers/find-match-resolution.ts';
 import { refMutationAdmissionResponse } from '../../src/daemon/handlers/interaction-ref-policy.ts';
-import { buildDeviceInUseBySessionError } from '../../src/daemon/handlers/session-open.ts';
+import { buildDeviceInUseBySessionError } from '../../src/daemon/session-recovery-hints.ts';
 import { buildDeviceClaimConflictError } from '../../src/daemon/device-claim-conflict.ts';
 import { resolveRefStalenessWarning } from '../../src/daemon/session-snapshot.ts';
 import type { SessionState } from '../../src/daemon/types.ts';

scripts/help-conformance-sample-outputs.mjs

@@ -83,8 +83,7 @@ Detected an overly complex or slow accessibility tree. Fell back to the private-
 };
 
 // DEVICE_IN_USE from buildDeviceInUseBySessionError
-// (src/daemon/handlers/session-open.ts) — the parity test drives that exact
-// producer.
+// (src/daemon/session-recovery-hints.ts) — the parity test drives that exact producer.
 export const DEVICE_IN_USE_SAMPLE = {
   command: `agent-device press 'label="Place order"' --settle`,
   output: `Error (DEVICE_IN_USE): Device is already in use by session "checkout".

scripts/integration-progress-model.ts

@@ -342,7 +342,7 @@ function summarizeProviderScenarioFlagExclusions() {
     },
     {
       name: 'open foreground auto-resolution (RFC prototype)',
-      owner: 'daemon session-open-foreground handler unit tests',
+      owner: 'daemon session-open-foreground lifecycle unit tests',
       keys: ['foreground'],
     },
     {

scripts/layering/architecture-ownership.ts

@@ -17,12 +17,23 @@ const DAEMON_REPLAY_FACADE = {
 
 const DAEMON_SESSION_LIFECYCLE_FACADE = {
   root: 'src/daemon/session-lifecycle/index.ts',
-  exports: ['SessionInventoryCommandInput', 'handleSessionInventoryCommands'],
+  exports: [
+    'SessionInventoryCommandInput',
+    'SessionOpenCommandInput',
+    'handleSessionInventoryCommands',
+    'handleSessionOpenCommands',
+  ],
 } as const;
 
 export const SESSION_LIFECYCLE_RETIRED_HANDLER_PATHS = [
   'src/daemon/handlers/session-device-utils.ts',
   'src/daemon/handlers/session-runtime-admission.ts',
+  'src/daemon/handlers/session-open.ts',
+  'src/daemon/handlers/session-open-prepare.ts',
+  'src/daemon/handlers/session-open-execution.ts',
+  'src/daemon/handlers/session-open-foreground.ts',
+  'src/daemon/handlers/session-open-surface.ts',
+  'src/daemon/handlers/session-startup-metrics.ts',
 ] as const;
 
 export const LOGICAL_MODULE_POLICIES = [

scripts/layering/daemon-modularity.test.ts

@@ -262,12 +262,28 @@ test('session lifecycle rejects restored neutral helper paths', () => {
   assert.deepEqual(
     violations.map(({ message }) => message),
     [
-      'retired session lifecycle helper path was restored: src/daemon/handlers/session-device-utils.ts. Keep the neutral seam at its daemon owner instead of rebuilding a handler grab-bag.',
-      'retired session lifecycle helper path was restored: src/daemon/handlers/session-runtime-admission.ts. Keep the neutral seam at its daemon owner instead of rebuilding a handler grab-bag.',
+      'retired session lifecycle path was restored: src/daemon/handlers/session-device-utils.ts. Keep the neutral seam at its daemon owner instead of rebuilding a handler grab-bag.',
+      'retired session lifecycle path was restored: src/daemon/handlers/session-runtime-admission.ts. Keep the neutral seam at its daemon owner instead of rebuilding a handler grab-bag.',
     ],
   );
 });
 
+test('session lifecycle rejects any restored open handler path', () => {
+  const violations = checkRetiredSessionLifecyclePaths([
+    'src/daemon/handlers/session-open-regressed.ts',
+  ]);
+
+  assert.deepEqual(violations, [
+    {
+      rule: 'R10 daemon-modularity',
+      file: 'src/daemon/handlers/session-open-regressed.ts',
+      line: 1,
+      message:
+        'retired session lifecycle path was restored: src/daemon/handlers/session-open-regressed.ts. Keep the neutral seam at its daemon owner instead of rebuilding a handler grab-bag.',
+    },
+  ]);
+});
+
 test('R9 records zone ceilings and keeps engine files outside the largest component', () => {
   // One commands file and one engine file traded for two provider-webdriver ones, so the
   // total stays at the baseline and only the per-zone claims are on trial.

scripts/layering/daemon-modularity.ts

@@ -57,16 +57,19 @@ export function checkDaemonModularityRatchets(
 export function checkRetiredSessionLifecyclePaths(
   sourceFiles: readonly string[],
 ): LayeringViolation[] {
-  return SESSION_LIFECYCLE_RETIRED_HANDLER_PATHS.filter((file) => sourceFiles.includes(file)).map(
-    (file) => ({
-      rule: 'R10 daemon-modularity',
-      file,
-      line: 1,
-      message:
-        `retired session lifecycle helper path was restored: ${file}. ` +
-        'Keep the neutral seam at its daemon owner instead of rebuilding a handler grab-bag.',
-    }),
+  const restoredPaths = sourceFiles.filter(
+    (file) =>
+      SESSION_LIFECYCLE_RETIRED_HANDLER_PATHS.some((retiredPath) => retiredPath === file) ||
+      /^src\/daemon\/handlers\/session-open(?:-[^/]+)?\.ts$/.test(file),
   );
+  return restoredPaths.map((file) => ({
+    rule: 'R10 daemon-modularity',
+    file,
+    line: 1,
+    message:
+      `retired session lifecycle path was restored: ${file}. ` +
+      'Keep the neutral seam at its daemon owner instead of rebuilding a handler grab-bag.',
+  }));
 }
 
 function checkSessionStateBaseline(): LayeringViolation[] {

scripts/layering/model.test.ts

@@ -317,7 +317,7 @@ test('session-state writes are found by field, and non-daemon or undeclared name
       // reads and comparisons are not writes
       ['src/daemon/handlers/find.ts', "if (session.refFrameState === 'active') return;"],
       // a write into a sub-object is not a write to the field itself
-      ['src/daemon/handlers/session-open.ts', 'session.refFrameState.inner = 1;'],
+      ['src/daemon/handlers/session-probe.ts', 'session.refFrameState.inner = 1;'],
       // a different binding that happens to have a matching property
       ['src/daemon/handlers/session-close.ts', "other.refFrameState = 'expired';"],
     ]),

scripts/layering/session-state.ts

@@ -80,8 +80,8 @@ export const SESSION_STATE_FIELD_OWNERS: Readonly<Record<string, readonly string
   // Open execution owns the paired lease/claim transition after the handler has admitted one
   // lifecycle binding. Keeping the records together prevents request-policy routing from gaining
   // a second durable owner as the execution seam stays package-bound.
-  lease: ['src/daemon/handlers/session-open-execution.ts'],
-  deviceClaim: ['src/daemon/handlers/session-open-execution.ts'],
+  lease: ['src/daemon/session-lifecycle/internal/session-open-execution.ts'],
+  deviceClaim: ['src/daemon/session-lifecycle/internal/session-open-execution.ts'],
 
   // #1398 (ADR 0017 session-scoped echo protection amendment): the ephemeral
   // literal->placeholder registry is populated and consulted only at the

src/__tests__/platform-runtime-runtime-hints.test.ts

@@ -6,10 +6,7 @@ import {
   applyRuntimeHintValues,
   clearRuntimeHintValues,
 } from '../platform-runtime-runtime-hints.ts';
-import {
-  applyDeviceDefaultMetroHost,
-  runtimeHintValues,
-} from '../daemon/handlers/session-runtime.ts';
+import { applyDeviceDefaultMetroHost, runtimeHintValues } from '../daemon/session-runtime.ts';
 import { resolveRuntimeTransportHints } from '../utils/runtime-transport.ts';
 import type { DeviceInfo } from '@agent-device/kernel/device';
 import {