Get LinFrame from LinSignal

[C47D]

Hi,

I'm trying to get the frame that 'contains' a given signal by using the signal name, something like this

def get_frame_by_signal(unconditional_frames, signal_name: str):

    for frame in unconditional_frames:
        if frame._get_signal(signal_name) is not None:
            return frame

    return None

It seems to work, but I would like to know if there's a cleaner way since I'm not used to python.

Regards

[c4deszes]

In the latest version there's no back reference from signal to unconditional frame, this issue can be solved within the parser and looking at the standard we can assume that the relation is 1-to-1.

9.2.4.1 Unconditional frames
All signals within one frame definition, shall be published by the same node as specified in the published_by identifier for that frame.

Until this is implemented you should keep using your solution. One recommendation regarding Python is not to use functions/variables from the library starting with an underscore, that is used to indicate that it's private and therefore might break at one point. In the Frame object the only public reference to signals is frame.signal_map which is List of tuples where the first element is the offset and the second is the LinSignal object, but using this would make your function more complicated.

I will convert this discussion into an issue and try to schedule it for 0.14.0 along with the LDF saving feature.

[C47D]

Thanks for the reply and the suggestion, I'll keep the current implementation until 0.14.0 comes out.

[c4deszes]

The issue has been resolved and was released in 0.14.0, you can now use ldf.get_signal('Signal_name').frame to retrieve the unconditional frame the signal is used in.

I will mark this discussion as resolved.

[C47D]

Updated ldfparser and it's working as expected, thanks!