From 62fced955aa76ea4761f0a605864da106cafb31f Mon Sep 17 00:00:00 2001 From: Fabian Barbuia Date: Fri, 31 Jul 2026 09:38:13 +0200 Subject: [PATCH 1/2] MBS-10696: fix missing login context in webservice test --- tests/webservice_test.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/webservice_test.php b/tests/webservice_test.php index 23bb3c4..85414a6 100644 --- a/tests/webservice_test.php +++ b/tests/webservice_test.php @@ -40,10 +40,14 @@ final class webservice_test extends \advanced_testcase { /** * Test getting a simple value via webservice. * + * Runs in an isolated process because report_customsql_external includes the legacy + * lib/externallib.php, which enforces PHPUnit process isolation via require_phpunit_isolation(). + * * @runInSeparateProcess */ public function test_get_simple_value(): void { - $this->resetAfterTest(true); + $this->resetAfterTest(); + $this->setAdminUser(); $displayname = 'test_query_counting_itself'; $description = 'Count queries with exactly this name. Should be one.'; From 0335e1c238bbbbfa92208903f57bea285ca9a945 Mon Sep 17 00:00:00 2001 From: Philipp Memmel Date: Mon, 24 Aug 2026 06:40:15 +0000 Subject: [PATCH 2/2] MBS-10696: Remove unnecessary comment --- tests/webservice_test.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/webservice_test.php b/tests/webservice_test.php index 85414a6..0a7efb4 100644 --- a/tests/webservice_test.php +++ b/tests/webservice_test.php @@ -40,9 +40,6 @@ final class webservice_test extends \advanced_testcase { /** * Test getting a simple value via webservice. * - * Runs in an isolated process because report_customsql_external includes the legacy - * lib/externallib.php, which enforces PHPUnit process isolation via require_phpunit_isolation(). - * * @runInSeparateProcess */ public function test_get_simple_value(): void {