Scoreboard overlay incorrect position and missing text

[OzFalcon]

Scoreboard overlay incorrect position and missing text (Credits, Lives, Player #)
As per the attached image

Using latest master/commit
https://github.com/btolab/hypseus/tree/c6af13b1274bbeb3e0406c84db6b9a5b3ce0bc72

[vanfanel]

@OzFalcon @h0tw1r3 I would like to investigate this.
Scoreboard is being drawn in:

hypseus/src/video/video.cpp

Line 408 in 3f7c4cb

void draw_overlay_leds(unsigned int values[], int num_digits, int start_x,

The leds are drawn onto g_leds_surface, which is created here:

hypseus/src/video/video.cpp

Line 235 in 3f7c4cb

g_leds_surface =

As you can see, it's created as a 320x240 surface, and blitted onto g_overlay_texture with a 320x240 rect accordingly.

So, maybe the LED surface size is wrong? Maybe the blitting dimensions are wrong?
Any ideas are welcome.

[vanfanel]

@h0tw1r3 Do you have any clues on why Dragon's Lair 2 isn't displaying the hiscore tables? Thought it was working in Daphne, or maybe it's also missing upstream?

According to this thread:
https://www.daphne-emu.com:9443/phpBB3/viewtopic.php?t=2384
...overlay in DL2 should be available from 2007

Further investigation indicates that DL2 overlays should be working.
Seems like things are in place.

lair2 is defined as using overlays as in Daphne:

hypseus/src/game/lair2.cpp

Line 220 in 3f7c4cb

m_game_uses_video_overlay = true;

https://github.com/DavidGriffith/daphne/blob/36752844655cebd3d9da7ae422325bdbee93634c/src/game/lair2.cpp#L304

A call to video_blit() when overlay update is needed is in place in both cases:

hypseus/src/game/lair2.cpp

Line 690 in 3f7c4cb

if (m_game_uses_video_overlay && m_video_overlay_needs_update) blit();

https://github.com/DavidGriffith/daphne/blob/36752844655cebd3d9da7ae422325bdbee93634c/src/game/lair2.cpp#L804

So, what's missing on Hypseus??

[h0tw1r3]

Unless something has changed recently, this is not implemented upstream.
Overlay doesn't imply a scoreboard, but the scoreboard does require overlay support.

[h0tw1r3]

I also found this information, which seems interesting for enabling the game overlays in dlair2.
https://www.daphne-emu.com:9443/phpBB3/viewtopic.php?t=2384