Skip to content

Commit 3ed5fd9

Browse files
committed
ci: checkout adapter-hackernews for E2E; build it with local core dep
Made-with: Cursor
1 parent 7b768ca commit 3ed5fd9

2 files changed

Lines changed: 21 additions & 0 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,25 @@ jobs:
3434
- name: Test (unit)
3535
run: pnpm test
3636

37+
# E2E: checkout the HN adapter, patch its core dep, build it, then run E2E
38+
- name: Checkout adapter-hackernews for E2E
39+
uses: actions/checkout@v4
40+
with:
41+
repository: browserkit-dev/adapter-hackernews
42+
path: packages/adapter-hackernews
43+
44+
- name: Build adapter-hackernews for E2E
45+
working-directory: packages/adapter-hackernews
46+
run: |
47+
node -e "
48+
const pkg = JSON.parse(require('fs').readFileSync('package.json'));
49+
pkg.devDependencies['@browserkit/core'] = 'file:../core';
50+
pkg.peerDependencies['@browserkit/core'] = '>=0.1.0';
51+
require('fs').writeFileSync('package.json', JSON.stringify(pkg, null, 2));
52+
"
53+
npm install
54+
npm run build
55+
3756
- name: Test (E2E smoke)
3857
run: pnpm test:e2e
3958
timeout-minutes: 5

‎tests/e2e/smoke.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ const CLI = path.join(ROOT, "packages/core/dist/cli.js");
3737
const HN_ADAPTER = path.join(ROOT, "packages/adapter-hackernews/dist/index.js");
3838
const GD_ADAPTER = path.resolve(ROOT, "../browserkit-adapter-google-discover/dist/index.js");
3939

40+
const hnAdapterAvailable = fs.existsSync(HN_ADAPTER);
41+
4042
// Isolated data dir so this test never conflicts with the user's running daemon
4143
const E2E_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "browserkit-e2e-"));
4244

0 commit comments

Comments
 (0)