Commit 3a8db23
authored
fix(ci): drop paths-filter negation patterns that fire on docs-only PRs (#61)
dorny/paths-filter standalone negation patterns (`'!apps/api/**/*.md'`
and the like) don't behave like exclude-from-include rules — they
evaluate to true for ANY changed file that doesn't fit the inverse
pattern. Net effect: on a docs-only PR with no code touched, the
`code` filter still returned `true` because a docs `.mdx` file
doesn't match `apps/api/**/*.md`, so the negation "matched".
Concrete evidence: PR #58 (only changed `apps/docs/.../deployment.mdx`).
Every step in `apps-api-ci.yml`'s `validate` job ran — checkout,
filter, Bun, install, db migrations, full test suite, coverage,
production bundle. The buggy negation set `Filter code = true`, the
internal `if: steps.filter.outputs.code == 'true'` gates all
short-circuited to "run", and we hit a unit-test flake on a PR that
touched zero application code.
Removed the negation lines from all 10 affected workflows. The filter
now matches strictly on the positive paths (`apps/api/**`, `apps/ui/**`,
etc. + the workflow file itself). Trade-off: a `README.md` change
inside `apps/api/` will now trigger api-ci. That's acceptable — those
changes are rare, and the previous "fast-skip" optimisation wasn't
actually working anyway. Net effect on docs-only PRs: api-ci,
ui-validate, smoke, bootstrap-validate, validate-compose, and the
security workflows all now correctly skip-with-success in ~30 s
instead of running their full pipelines.
Files touched (10 workflows, 22 lines deleted):
apps-api-ci.yml
apps-api-security-{deps,sast,secrets}.yml
apps-ui-security-{deps,sast,secrets}.yml
apps-ui-validate.yml
infra-bootstrap-validate.yml
infra-compose-full-stack-smoke.yml
infra-compose-validate-compose.yml (3 filter blocks)
This PR self-verifies: it's workflow-only, so the `code` filter on
every affected workflow should now correctly evaluate to `false` on
this PR (no apps/api, apps/ui, infra/* changes), and the heavy jobs
should report quick green via skip-with-success. If you see Bun
install + full test suite running on this PR, the fix is wrong.1 parent 958f463 commit 3a8db23
11 files changed
Lines changed: 0 additions & 22 deletions
File tree
- .github/workflows
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | 88 | | |
91 | 89 | | |
92 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | 45 | | |
48 | 46 | | |
49 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | 58 | | |
61 | 59 | | |
62 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | 49 | | |
52 | 50 | | |
53 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | 45 | | |
48 | 46 | | |
49 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | 57 | | |
60 | 58 | | |
61 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | 49 | | |
52 | 50 | | |
53 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | 37 | | |
40 | 38 | | |
41 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
63 | | - | |
64 | 62 | | |
65 | 63 | | |
66 | 64 | | |
| |||
0 commit comments