Fails to build against kernel 5.11.x

[rathann]

It looks like nearly all of the structs defined in include/h264-ctrls.h are defined in /usr/include/linux/v4l2-controls.h already:

$ /usr/bin/meson compile -C aarch64-redhat-linux-gnu --verbose
Found runner: ['/usr/bin/ninja']
ninja: Entering directory `aarch64-redhat-linux-gnu'
[1/4] gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/h264.c.o -MF src/v4l2_request_drv_video.so.p/h264.c.o.d -o src/v4l2_request_drv_video.so.p/h264.c.o -c ../src/h264.c
FAILED: src/v4l2_request_drv_video.so.p/h264.c.o 
gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/h264.c.o -MF src/v4l2_request_drv_video.so.p/h264.c.o.d -o src/v4l2_request_drv_video.so.p/h264.c.o -c ../src/h264.c
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:52:8: error: redefinition of ‘struct v4l2_ctrl_h264_sps’
   52 | struct v4l2_ctrl_h264_sps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1273:8: note: originally defined here
 1273 | struct v4l2_ctrl_h264_sps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:82:8: error: redefinition of ‘struct v4l2_ctrl_h264_pps’
   82 | struct v4l2_ctrl_h264_pps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1329:8: note: originally defined here
 1329 | struct v4l2_ctrl_h264_pps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:96:8: error: redefinition of ‘struct v4l2_ctrl_h264_scaling_matrix’
   96 | struct v4l2_ctrl_h264_scaling_matrix {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1361:8: note: originally defined here
 1361 | struct v4l2_ctrl_h264_scaling_matrix {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:101:8: error: redefinition of ‘struct v4l2_h264_weight_factors’
  101 | struct v4l2_h264_weight_factors {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1366:8: note: originally defined here
 1366 | struct v4l2_h264_weight_factors {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:122: warning: "V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED" redefined
  122 | #define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED     0x04
      | 
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1403: note: this is the location of the previous definition
 1403 | #define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED     0x01
      | 
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:123: warning: "V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH" redefined
  123 | #define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH              0x08
      | 
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1404: note: this is the location of the previous definition
 1404 | #define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH              0x02
      | 
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:125:8: error: redefinition of ‘struct v4l2_ctrl_h264_slice_params’
  125 | struct v4l2_ctrl_h264_slice_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1464:8: note: originally defined here
 1464 | struct v4l2_ctrl_h264_slice_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:173:8: error: redefinition of ‘struct v4l2_h264_dpb_entry’
  173 | struct v4l2_h264_dpb_entry {
      |        ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1509:8: note: originally defined here
 1509 | struct v4l2_h264_dpb_entry {
      |        ^~~~~~~~~~~~~~~~~~~
In file included from ../src/h264.c:36:
../include/h264-ctrls.h:185:8: error: redefinition of ‘struct v4l2_ctrl_h264_decode_params’
  185 | struct v4l2_ctrl_h264_decode_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/h264.c:35:
/usr/include/linux/v4l2-controls.h:1546:8: note: originally defined here
 1546 | struct v4l2_ctrl_h264_decode_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
[2/4] gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/context.c.o -MF src/v4l2_request_drv_video.so.p/context.c.o.d -o src/v4l2_request_drv_video.so.p/context.c.o -c ../src/context.c
FAILED: src/v4l2_request_drv_video.so.p/context.c.o 
gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/context.c.o -MF src/v4l2_request_drv_video.so.p/context.c.o.d -o src/v4l2_request_drv_video.so.p/context.c.o -c ../src/context.c
In file included from ../src/context.c:43:
../include/h264-ctrls.h:52:8: error: redefinition of ‘struct v4l2_ctrl_h264_sps’
   52 | struct v4l2_ctrl_h264_sps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1273:8: note: originally defined here
 1273 | struct v4l2_ctrl_h264_sps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from ../src/context.c:43:
../include/h264-ctrls.h:82:8: error: redefinition of ‘struct v4l2_ctrl_h264_pps’
   82 | struct v4l2_ctrl_h264_pps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1329:8: note: originally defined here
 1329 | struct v4l2_ctrl_h264_pps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from ../src/context.c:43:
../include/h264-ctrls.h:96:8: error: redefinition of ‘struct v4l2_ctrl_h264_scaling_matrix’
   96 | struct v4l2_ctrl_h264_scaling_matrix {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1361:8: note: originally defined here
 1361 | struct v4l2_ctrl_h264_scaling_matrix {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/context.c:43:
../include/h264-ctrls.h:101:8: error: redefinition of ‘struct v4l2_h264_weight_factors’
  101 | struct v4l2_h264_weight_factors {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1366:8: note: originally defined here
 1366 | struct v4l2_h264_weight_factors {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/context.c:43:
../include/h264-ctrls.h:122: warning: "V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED" redefined
  122 | #define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED     0x04
      | 
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1403: note: this is the location of the previous definition
 1403 | #define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED     0x01
      | 
In file included from ../src/context.c:43:
../include/h264-ctrls.h:123: warning: "V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH" redefined
  123 | #define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH              0x08
      | 
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1404: note: this is the location of the previous definition
 1404 | #define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH              0x02
      | 
In file included from ../src/context.c:43:
../include/h264-ctrls.h:125:8: error: redefinition of ‘struct v4l2_ctrl_h264_slice_params’
  125 | struct v4l2_ctrl_h264_slice_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1464:8: note: originally defined here
 1464 | struct v4l2_ctrl_h264_slice_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/context.c:43:
../include/h264-ctrls.h:173:8: error: redefinition of ‘struct v4l2_h264_dpb_entry’
  173 | struct v4l2_h264_dpb_entry {
      |        ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1509:8: note: originally defined here
 1509 | struct v4l2_h264_dpb_entry {
      |        ^~~~~~~~~~~~~~~~~~~
In file included from ../src/context.c:43:
../include/h264-ctrls.h:185:8: error: redefinition of ‘struct v4l2_ctrl_h264_decode_params’
  185 | struct v4l2_ctrl_h264_decode_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/context.c:28:
/usr/include/linux/v4l2-controls.h:1546:8: note: originally defined here
 1546 | struct v4l2_ctrl_h264_decode_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
[3/4] gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/config.c.o -MF src/v4l2_request_drv_video.so.p/config.c.o.d -o src/v4l2_request_drv_video.so.p/config.c.o -c ../src/config.c
FAILED: src/v4l2_request_drv_video.so.p/config.c.o 
gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/config.c.o -MF src/v4l2_request_drv_video.so.p/config.c.o.d -o src/v4l2_request_drv_video.so.p/config.c.o -c ../src/config.c
In file included from ../src/config.c:38:
../include/h264-ctrls.h:52:8: error: redefinition of ‘struct v4l2_ctrl_h264_sps’
   52 | struct v4l2_ctrl_h264_sps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1273:8: note: originally defined here
 1273 | struct v4l2_ctrl_h264_sps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from ../src/config.c:38:
../include/h264-ctrls.h:82:8: error: redefinition of ‘struct v4l2_ctrl_h264_pps’
   82 | struct v4l2_ctrl_h264_pps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1329:8: note: originally defined here
 1329 | struct v4l2_ctrl_h264_pps {
      |        ^~~~~~~~~~~~~~~~~~
In file included from ../src/config.c:38:
../include/h264-ctrls.h:96:8: error: redefinition of ‘struct v4l2_ctrl_h264_scaling_matrix’
   96 | struct v4l2_ctrl_h264_scaling_matrix {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1361:8: note: originally defined here
 1361 | struct v4l2_ctrl_h264_scaling_matrix {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/config.c:38:
../include/h264-ctrls.h:101:8: error: redefinition of ‘struct v4l2_h264_weight_factors’
  101 | struct v4l2_h264_weight_factors {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1366:8: note: originally defined here
 1366 | struct v4l2_h264_weight_factors {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/config.c:38:
../include/h264-ctrls.h:122: warning: "V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED" redefined
  122 | #define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED     0x04
      | 
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1403: note: this is the location of the previous definition
 1403 | #define V4L2_H264_SLICE_FLAG_DIRECT_SPATIAL_MV_PRED     0x01
      | 
In file included from ../src/config.c:38:
../include/h264-ctrls.h:123: warning: "V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH" redefined
  123 | #define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH              0x08
      | 
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1404: note: this is the location of the previous definition
 1404 | #define V4L2_H264_SLICE_FLAG_SP_FOR_SWITCH              0x02
      | 
In file included from ../src/config.c:38:
../include/h264-ctrls.h:125:8: error: redefinition of ‘struct v4l2_ctrl_h264_slice_params’
  125 | struct v4l2_ctrl_h264_slice_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1464:8: note: originally defined here
 1464 | struct v4l2_ctrl_h264_slice_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../src/config.c:38:
../include/h264-ctrls.h:173:8: error: redefinition of ‘struct v4l2_h264_dpb_entry’
  173 | struct v4l2_h264_dpb_entry {
      |        ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1509:8: note: originally defined here
 1509 | struct v4l2_h264_dpb_entry {
      |        ^~~~~~~~~~~~~~~~~~~
In file included from ../src/config.c:38:
../include/h264-ctrls.h:185:8: error: redefinition of ‘struct v4l2_ctrl_h264_decode_params’
  185 | struct v4l2_ctrl_h264_decode_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/linux/videodev2.h:65,
                 from ../src/request.h:37,
                 from ../src/config.h:33,
                 from ../src/config.c:27:
/usr/include/linux/v4l2-controls.h:1546:8: note: originally defined here
 1546 | struct v4l2_ctrl_h264_decode_params {
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

If I patch out all the struct definitions, I get this error:

[13/18] gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/h264.c.o -MF src/v4l2_request_drv_video.so.p/h264.c.o.d -o src/v4l2_request_drv_video.so.p/h264.c.o -c ../src/h264.c
FAILED: src/v4l2_request_drv_video.so.p/h264.c.o 
gcc -Isrc/v4l2_request_drv_video.so.p -Isrc -I../src -I../include -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -fPIC -Wall -fvisibility=hidden -MD -MQ src/v4l2_request_drv_video.so.p/h264.c.o -MF src/v4l2_request_drv_video.so.p/h264.c.o.d -o src/v4l2_request_drv_video.so.p/h264.c.o -c ../src/h264.c
../src/h264.c: In function ‘h264_va_picture_to_v4l2’:
../src/h264.c:223:15: error: ‘struct v4l2_ctrl_h264_decode_params’ has no member named ‘num_slices’
  223 |         decode->num_slices = surface->slices_count;
      |               ^~
../src/h264.c: In function ‘h264_va_slice_to_v4l2’:
../src/h264.c:332:14: error: ‘struct v4l2_ctrl_h264_slice_params’ has no member named ‘size’
  332 |         slice->size = VASlice->slice_data_size;
      |              ^~
../src/h264.c:359:51: error: incompatible types when assigning to type ‘struct v4l2_h264_reference’ from type ‘unsigned int’
  359 |                         slice->ref_pic_list0[i] = idx;
      |                                                   ^~~
../src/h264.c:378:51: error: incompatible types when assigning to type ‘struct v4l2_h264_reference’ from type ‘unsigned int’
  378 |                         slice->ref_pic_list1[i] = idx;
      |                                                   ^~~
../src/h264.c:385:14: error: ‘struct v4l2_ctrl_h264_slice_params’ has no member named ‘pred_weight_table’
  385 |         slice->pred_weight_table.chroma_log2_weight_denom =
      |              ^~
../src/h264.c:387:14: error: ‘struct v4l2_ctrl_h264_slice_params’ has no member named ‘pred_weight_table’
  387 |         slice->pred_weight_table.luma_log2_weight_denom =
      |              ^~
../src/h264.c:392:44: error: ‘struct v4l2_ctrl_h264_slice_params’ has no member named ‘pred_weight_table’
  392 |                 h264_copy_pred_table(&slice->pred_weight_table.weight_factors[0],
      |                                            ^~
../src/h264.c:400:44: error: ‘struct v4l2_ctrl_h264_slice_params’ has no member named ‘pred_weight_table’
  400 |                 h264_copy_pred_table(&slice->pred_weight_table.weight_factors[1],
      |                                            ^~

[bjharper]

Im having the same problem and looks like h264 definitions in the kernel have been updated for example https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.11.21&id=2287c5e65cbcc99633c412dbfe1d39bd9f7bf1ce

I did try to hack in some changes too see if I could sync up the api changes and use the headers from the 5.11 kernel but getting too deep for me to understand. At runtime I was left with:

$ LIBVA_DRIVER_NAME=v4l2_request LIBVA_DRIVERS_PATH=/usr/local/lib/aarch64-linux-gnu/dri vainfo libva info: VA-API version 1.8.0 libva info: User environment variable requested driver 'v4l2_request' libva info: Trying to open /usr/local/lib/aarch64-linux-gnu/dri/v4l2_request_drv_video.so libva error: dlopen of /usr/local/lib/aarch64-linux-gnu/dri/v4l2_request_drv_video.so failed: /usr/local/lib/aarch64-linux-gnu/dri/v4l2_request_drv_video.so: undefined symbol: tiled_to_planar libva info: va_openDriver() returns -1 vaInitialize failed with error code -1 (unknown libva error),exit .
Would be great if someone with more experiance could take a look at the new kernel changes

Edit: The tiled_to_planar issue seems resolved in this pull request #32 for aarch64 but still vaInitialize errors that I don't have the expertise to understand:

$ LIBVA_DRIVER_NAME=v4l2_request LIBVA_DRIVERS_PATH=/usr/local/lib/aarch64-linux-gnu/dri vainfo libva info: VA-API version 1.8.0 libva info: User environment variable requested driver 'v4l2_request' libva info: Trying to open /usr/local/lib/aarch64-linux-gnu/dri/v4l2_request_drv_video.so libva info: Found init function __vaDriverInit_1_8 libva error: /usr/local/lib/aarch64-linux-gnu/dri/v4l2_request_drv_video.so init failed libva info: va_openDriver() returns 1 vaInitialize failed with error code 1 (operation failed),exit

[wolfallein]

I can confirm that I cannot compile it for kernel 5.12. In the past, I was able to get it working for kernel 5.7, making small changes to the kernel source to revert the new h264 definitions that @bjharper mentioned, see #31. Now the kernel sources are much more complicated to follow what changed in the h264 def. and I could not revert it, although it would be much better to modify the libva-v4l2-request to follow the kernel modifications. Unfortunately, I have no idea how to do it and already spent many hours on it.

It is a pity that a lot of work was done to get Cedrus working in the past, and we cannot use it after 2 years that the development stopped. I'm afraid that Cedrus will never go from stagging and may be dropped from the kernel sources entirely.

[jernejsk]

There is no intention to drop Cedrus. In fact, there is a talk to promote it to stable in near future, together with Hantro. This library is not maintained though. Easy way to use it would be 5.12 kernel and gstreamer build from latest development sources. Another possibility would be ffmpeg with additional patches...

[wolfallein]

@jernejsk That is very good news! I'm already using kernel 5.12. Can you point me to the GStreamer version that would work? I heard about this patched ffmpeg version, is this patch from LibreELEC you are referring to? Should I use it the same way as in:

ffmpeg -hwaccel vaapi -hwaccel_device /dev/video1 -hwaccel_output_format vaapi -i video.mp4 -f null /dev/null

would this work? I'll try it fast :)

Thank you!

[jernejsk]

As I said, use latest gstreamer development sources from git. Latest stable version doesn't include necessary improvements yet. And I don't know what command would be needed to actually use Cedrus. Check #linux-sunxi IRC log.

Regarding ffmpeg, that patchset is for kernel 5.10 and it presumes that additional kernel patches are applied for codecs other than H264. And no, that line won't work. Those patches have nothing to do with VAAPI.

Something like this may work:
ffmpeg -hwaccel drm -hwaccel_device /dev/dri/card0 -hwaccel_output_format drm_prime -i video.mkv -f null -

Both approaches were already discussed on #linux-sunxi IRC and Armbian forum, so I suggest you check there for further info.

[rathann]

That won't help with Firefox, which is using VA-API for hardware video decoding. Or Chromium with the unofficial patch that most distributions are using. We really need a working VA-API driver for the most common use case here. Regarding the FFmpeg patch, I have seen no response from its author to initial review on the developer mailing list, so I don't think it's going to be included any time soon.

[bjharper]

Yes I'm looking for VA-API solution for amlogic platforms (particularly for firefox / chromium). . I might have another go at resolving some of the issues interfacing with the newer kernel but it will be a big learning curve for me. ffmpeg with v4l2 decoder is working ok on my platform.

[jernejsk]

@rathann The thing is: development is driven by developer needs or contracts. In my case, I only care about Cedrus and ffmpeg (I'm co-author of ffmpeg patches) since I need them for Kodi on LibreELEC. Collabora mostly works only on Hantro and gstreamer. You can still check status of forks of this repo - at least one updated some codecs in the past.

Regarding ffmpeg patches - there is still plan to send updated version but some parts need redesign (apart from addressing comments). Since V4L2 request API is still evolving and we don't have much spare time for this, it will take a while longer.

@bjharper Amlogic V4L2 codecs don't use request API, so this is useless. They expect to receive full frames, while VA-API and V4L2 request API codecs expect to get parsed frames (extracted information from frame header). This is not a driver thing - it's how HW is designed. Technically it would be possible to restore full frames from VA-API data, but it's complicated.

[wolfallein]

Looking for more information, I found this video on YouTube from Collabora, they explain the actual status of the decoder. At 31:11, Nicolas Dufresne (one of the developers behind Cedrus and Gstreamer Cedrus support) said they stopped developing this VA-API driver since FFmpeg, GStreamer and Chromium already have support.

Any further development on this VA-API driver needs to come from the community. I believe they assume that there is no need for the VA-API if the application can directly access the decoder with the recent kernel development. This means that it will take a while for everything to get patched (or maybe never will).

It is a pity because Firefox took so long to support VA-API, and now that it finally supports hardware video decoding on Linux, Cedrus doesn't support it anymore. I know Firefox uses FFmpeg for some tasks, but I don't know if it uses (or can use) for video decoding.

@jernejsk Thank you for your work on the FFmpeg patches :). I can also confirm that Gstreamer works with hardware acceleration. I needed to compile it (version 1.19.0.1), and I used the following to test:

gst-launch-1.0 filesrc location=video.MP4 ! qtdemux ! h264parse ! v4l2slh264dec ! autovideosink

It works even on top of Wayland, very nice. However, I had some problems with 60fps 1080p videos, everything lower than this works without problems (maybe I need to add more CMA). To test with software decoding, I used avdec_h264 instead of v4l2slh264dec. With hardware decoding, the CPU load is very small, amazing.

[wolfallein]

Hi,

I got the libva-v4l2-request to compile and run on Linux 5.12.
The library had some initialization issues because the way the driver works changed recently in the newer kernel. I tried to follow what is written in the stateless decoder initialization documentation: Memory-to-memory Stateless Video Decoder Interface.

It turns out we need to free the capture buffers. Apart from that, there are a couple of structs that changed, and some definition names as well, for instance: the control V4L2_CID_MPEG_VIDEO_H264_SPS changed to V4L2_CID_STATELESS_H264_SPS.

I also tried to follow what the people from GStreamer did to get it to work on the merge-request that added cedrus support.

when I run:

ffmpeg -hwaccel vaapi -hwaccel_device /dev/video1 -hwaccel_output_format vaapi -i video.mp4 -f null -

Everything seems fine, I don't get any driver errors, and the decoding speed is around 10x with a small load on the CPU, in line with what I would expect for hardware decoding. With software decoding for the same video, I get around 2x with all the cores at 100%.

when I run cvlc or ffmpeg with output to fbdev, like in:

ffmpeg -hwaccel vaapi -hwaccel_device /dev/video1 -i video.mp4 -pix_fmt bgra -f fbdev /dev/fb0

The video image is not correct. It seems that we still need to set the video output format, or there is still something missing in the initialization. Maybe it is now that the problem really starts :-) The noisy image is dynamic, and it seems that the hardware decoding is going on but in the wrong video format.

Since I'm not a developer by any means, and I know nothing about video decoding/encoding, v4l2 implementation... And I don't get any error to debug. I don't really know where to look to find the cause of this problem. It would be very good if someone can point me in a direction and indicate an example to follow. Any help is welcome. @jernejsk do you have any idea where I could look to fix it?

I think libva on Cedrus is very important because it would make the driver compatible with much more software already developed.

You can see the changes I made to get to this stage on my fork, on this commit. I adapted a few changes from pH5 on #29 and the Tile format fix from Kwizart on #32.

Thank you all,
Best regards

[jernejsk]

Not really, no. Most probably some field in some control is not set correctly. Now comes the hard part - dumping register values (on kernel side) or dumping control values (on userspace side) and comparing them...

[wolfallein]

@jernejsk thank you. The problem also happens with MPEG2 videos. Most of the changes in the kernel were for h264...

So, maybe it is something before we send the slices. I noticed that on the GStreamer patch that they set a single control (V4L2_CID_STATELESS_H264_SPS) before sending a VIDIOC_STREAMON.

On the MPEG2 decoding, we set only two controls: V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS and V4L2_CID_MPEG_VIDEO_MPEG2_QUANTIZATION.

[openedev]

@wolfallein Thanks for testing it on gstreamer.

I'm trying the same where I've built the gstreamer master since there seems to be some changes related to v4l2codes/h264 has been merged recently.

It is not playing while I've used the below pipeline, one you mentioned on the same thread.

# gst-launch-1.0 filesrc location=video.MP4 ! qtdemux ! h264parse ! v4l2slh264dec ! autovideosink
0:00:00.127261534   311   0x557440 DEBUG             v4l2codecs gstv4l2codecdevice.c:331:gst_v4l2_codec_find_devices: Analysing media device '/dev/media0'
0:00:00.127394571   311   0x557440 DEBUG             v4l2codecs gstv4l2codecdevice.c:347:gst_v4l2_codec_find_devices: Found CODEC entities
0:00:00.127462984   311   0x557440 DEBUG             v4l2codecs gstv4l2codecdevice.c:357:gst_v4l2_codec_find_devices: Analysing entity cedrus-proc
0:00:00.127501774   311   0x557440 DEBUG             v4l2codecs gstv4l2codecdevice.c:362:gst_v4l2_codec_find_devices: Found source and sink pads
0:00:00.127536731   311   0x557440 DEBUG             v4l2codecs gstv4l2codecdevice.c:370:gst_v4l2_codec_find_devices: Found source and sink V4L IO entities
0:00:00.127926840   311   0x557440 INFO              v4l2codecs gstv4l2codecdevice.c:388:gst_v4l2_codec_find_devices: Found decoder device cedrus-proc
0:00:00.128658268   311   0x557440 DEBUG     v4l2codecs-decoder gstv4l2decoder.c:306:gst_v4l2_decoder_enum_sink_fmt:<v4l2decoder0> Found format MG2S (MPEG-2 Parsed Slice Data)
0:00:00.128730682   311   0x557440 FIXME             v4l2codecs plugin.c:62:register_video_decoder:<v4l2decoder0> MG2S is not supported.
0:00:00.128797263   311   0x557440 DEBUG     v4l2codecs-decoder gstv4l2decoder.c:306:gst_v4l2_decoder_enum_sink_fmt:<v4l2decoder0> Found format S264 (H.264 Parsed Slice Data)
0:00:00.128842052   311   0x557440 INFO              v4l2codecs plugin.c:50:register_video_decoder:<v4l2decoder0> Registering cedrus-proc as H264 Decoder
0:00:00.129259827   311   0x557440 DEBUG     v4l2codecs-decoder gstv4l2decoder.c:306:gst_v4l2_decoder_enum_sink_fmt:<v4l2decoder0> Found format S265 (HEVC Parsed Slice Data)
0:00:00.129324532   311   0x557440 FIXME             v4l2codecs plugin.c:62:register_video_decoder:<v4l2decoder0> S265 is not supported.
0:00:00.129385280   311   0x557440 DEBUG     v4l2codecs-decoder gstv4l2decoder.c:306:gst_v4l2_decoder_enum_sink_fmt:<v4l2decoder0> Found format VP8F (VP8 Frame)
0:00:00.129428820   311   0x557440 INFO              v4l2codecs plugin.c:56:register_video_decoder:<v4l2decoder0> Registering cedrus-proc as VP8 Decoder
Setting pipeline to PAUSED ...
0:00:00.341702592   311   0x557440 INFO      v4l2codecs-h264dec gstv4l2codech264dec.c:221:gst_v4l2_codec_h264_dec_open:<v4l2slh264dec0> Opened H264 slice based decoder without start-codes
Pipeline is PREROLLING ...
WARNING: from element /GstPipeline:pipeline0/GstQTDemux:qtdemux0: Delayed linking failed.
Additional debug info:
gst/parse/grammar.y(540): gst_parse_no_more_pads (): /GstPipeline:pipeline0/GstQTDemux:qtdemux0:
failed delayed linking some pad of GstQTDemux named qtdemux0 to some pad of GstH264Parse named h264parse0
ERROR: from element /GstPipeline:pipeline0/GstQTDemux:qtdemux0: Internal data stream error.
Additional debug info:
../git/gst/isomp4/qtdemux.c(6650): gst_qtdemux_loop (): /GstPipeline:pipeline0/GstQTDemux:qtdemux0:
streaming stopped, reason not-linked (-1)
ERROR: pipeline doesn't want to preroll.
Setting pipeline to NULL ...
Freeing pipeline ...

However it is playing while I have passed the videoconvert in between decoder and autovideosink but it is playing slow even for 720p video.

# gst-launch-1.0 filesrc location=video.MP4 ! qtdemux ! h264parse ! v4l2slh264dec ! videoconvert ! autovideosink

These are my systems details:

Allwinner H3 SoC
Linux-5.13 Stable
Gstreamer (master branch)
# gst-inspect-1.0 --version
gst-inspect-1.0 version 1.19.1
GStreamer 1.19.1 (GIT)
Unknown package origin

Please let me know if I miss anything? May be sharing your root can cross-check if anything missing on my gst configuration?

Jagan.

[danboid]

Hi @jernejsk

I want to try to get v4l2-request working with ffmpeg under Armbian buster on my T95 Max H6 TV box as the stepping stone to mpv.

Which version or commit of ffmpeg is your patch for? It doesn't seem to apply cleanly to ffmpeg 5.0 nor the latest git version and it seems you only updated it 10 days ago.

Thanks