Pull Request Review
This PR primarily hardens CI/workflow security and updates toolchain usage (checkout/cache/github-script versions, pinning semantic PR action by commit, moving to npm cache, and passing PR-derived values via env). It also strengthens scripts/check-bsc-hardfork-bytecode.ts by replacing shell-based execSync with execFileSync, adding strict input validation for hardfork/ref values, and using isolated temporary clone directories with cleanup. In smart contracts, it fixes governance blacklist bypass for signature-based voting and improves validator slashing/eviction handling around consensus-key rotation, with corresponding regression tests and hardfork config updates in genesis templates.
Sensitive Content
Blockchain Address:
0x08E68Ec70FA3b629784fDB28887e206ce8561E08 (Ethereum/BSC address) in test/GovernorBlacklistBySig.t.sol — hardcoded governor protector test constant.0x23618e81E3f5cdF7f54C3d65f7FBc0aBf5B21E8f (Ethereum/BSC address) in test/SlashIndicator.t.sol — mock validator in double-sign test.
Security Issues
No serious security issues detected.
Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.
Originally posted by @hashdit-bot[bot] in #669 (comment)
Pull Request Review
This PR primarily hardens CI/workflow security and updates toolchain usage (checkout/cache/github-script versions, pinning semantic PR action by commit, moving to npm cache, and passing PR-derived values via
env). It also strengthensscripts/check-bsc-hardfork-bytecode.tsby replacing shell-basedexecSyncwithexecFileSync, adding strict input validation for hardfork/ref values, and using isolated temporary clone directories with cleanup. In smart contracts, it fixes governance blacklist bypass for signature-based voting and improves validator slashing/eviction handling around consensus-key rotation, with corresponding regression tests and hardfork config updates in genesis templates.Sensitive Content
Blockchain Address:
0x08E68Ec70FA3b629784fDB28887e206ce8561E08(Ethereum/BSC address) intest/GovernorBlacklistBySig.t.sol— hardcoded governor protector test constant.0x23618e81E3f5cdF7f54C3d65f7FBc0aBf5B21E8f(Ethereum/BSC address) intest/SlashIndicator.t.sol— mock validator in double-sign test.Security Issues
No serious security issues detected.
Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.
Originally posted by @hashdit-bot[bot] in #669 (comment)