From d69acf17643f10b026ee29a7122d83373cd14184 Mon Sep 17 00:00:00 2001 From: Andrew Ruthven Date: Sat, 21 Mar 2026 12:25:11 +1300 Subject: [PATCH 1/2] Fix sprintf formatting The call to croakf is passing in 4 parameters, but the formatting string only used 3 of them. This resulted in an error message like: Redundant argument in sprintf at /usr/share/perl5/GitLab/API/v4/RESTClient.pm line 69. --- lib/GitLab/API/v4/RESTClient.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/GitLab/API/v4/RESTClient.pm b/lib/GitLab/API/v4/RESTClient.pm index 62be391..5771fa0 100644 --- a/lib/GitLab/API/v4/RESTClient.pm +++ b/lib/GitLab/API/v4/RESTClient.pm @@ -247,7 +247,7 @@ sub request { } catch { croakf( - 'Error decoding JSON (%s %s %s): ', + 'Error decoding JSON (%s %s %s): %s', $verb, $url, $res->{status}, $_, ); }; From 388171f099e342161ffa2ee5df782936398cb87c Mon Sep 17 00:00:00 2001 From: Andrew Ruthven Date: Sat, 21 Mar 2026 12:14:12 +1300 Subject: [PATCH 2/2] Fix fetching job trace files These files are plain text and can't be decoded. --- lib/GitLab/API/v4.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/GitLab/API/v4.pm b/lib/GitLab/API/v4.pm index eb3dde7..55dbb66 100644 --- a/lib/GitLab/API/v4.pm +++ b/lib/GitLab/API/v4.pm @@ -4170,7 +4170,7 @@ sub job_trace_file { croak 'job_trace_file must be called with 2 arguments' if @_ != 2; croak 'The #1 argument ($project_id) to job_trace_file must be a scalar' if ref($_[0]) or (!defined $_[0]); croak 'The #2 argument ($job_id) to job_trace_file must be a scalar' if ref($_[1]) or (!defined $_[1]); - my $options = {}; + my $options = {decode => 0}; return $self->_call_rest_client( 'GET', 'projects/:project_id/jobs/:job_id/trace', [@_], $options ); }