Skip to content

Ingress should use named ports for httpcache service #142

Description

@jensens

Problem

PloneIngress hardcodes port: { number: 80 } for all httpcache service references. This breaks with PloneVinylCache where the traffic service runs on port 8080.

Root cause

The port number is a detail of the cache implementation:

  • PloneHttpcache (kube-httpcache): port 80
  • PloneVinylCache (cloud-vinyl): port 8080

The ingress shouldn't need to know this.

Solution

Use named port references (port: { name: "http" }) in ingress rules instead of numeric ports. Both cache implementations already define named ports on their services. Named ports decouple the ingress from the cache implementation's port choice.

Alternatively, PloneIngress could accept the port from the cache construct that knows its own port. But named ports are cleaner and more Kubernetes-idiomatic.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions