Skip to content

Add attachments module with S3-backed signed upload/download flow #53

Add attachments module with S3-backed signed upload/download flow

Add attachments module with S3-backed signed upload/download flow #53

Triggered via pull request April 22, 2026 03:57
Status Failure
Total duration 1m 35s
Artifacts

go.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
Lint: internal/attachments/domain.go#L53
Magic number: 255, in <condition> detected (mnd)
Lint: internal/server/attachments/handler.go#L113
shadow: declaration of "err" shadows declaration at line 103 (govet)
Lint: internal/attachments/service.go#L112
shadow: declaration of "err" shadows declaration at line 99 (govet)
Lint: internal/server/tasks/dto.go#L156
File is not properly formatted (golines)
Lint: internal/s3/client.go#L26
File is not properly formatted (golines)
Lint: internal/attachments/service.go#L86
File is not properly formatted (golines)
Lint: internal/s3/module.go#L14
minio.Options is missing fields Transport, Trace, Region, BucketLookup, CustomRegionViaURL, BucketLookupViaURL, TrailingHeaders, CustomMD5, CustomSHA256, MaxRetries (exhaustruct)
Lint: internal/s3/client.go#L45
minio.RemoveObjectOptions is missing fields ForceDelete, GovernanceBypass, VersionID, Internal (exhaustruct)
Lint: internal/attachments/models.go#L25
attachments.attachmentModel is missing fields BaseModel, ID, TaskAuthorID (exhaustruct)
Lint: internal/attachments/service.go#L30
there must be an empty line separating embedded fields from regular fields (embeddedstructfieldcheck)
Lint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, golangci/golangci-lint-action@v8. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Test
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/