[Bug]: Additional Pokémon showing up in Team Viewer After Battle with Teammate

[chandlerbogolin]

Describe the bug

In Pokémon Emerald, after the fight where you team up with Steven against Team Magma, the Pokémon he picks for his team confuse the team viewer, and end up sticking around even after trying to reset it with my own Pokémon from the PC. I assume this issue would probably occur with any dual battle with a teammate. tried refreshing the tracker, but that didn't seem to fix it.

Steps to Reproduce

1. Make it to Mossdeep city
2. fight team magma
3. make it to boss battle
4. team up with Steven
5. selected only 1 pokemon for myself (not sure if that mattered or not but felt it was worth noting)
6. after the battle, team viewer should be broken

What tracker version are you using?

v7.5.3

What operating system are you using?

Windows 10

What emulator(s) are you seeing the problem on?

Bizhawk 2.9

Relevant log output

No response

Additional Information

[UTDZac]

Thank you for the bug report and detailed notes with images. This should be fixed in eb67ca8

[UTDZac]

Whoops, I seem to have replied to the wrong conversation around the Team Viewer. I believe this one has yet to be resolved, and is not currently fixed. Sorry about that.

[Fellshadow]

Took some time to see if I could reproduce this on the current dev version (9.2.4 as labelled in-dev) while I was checking some other things on a vanilla emerald game

During the Steven fight, the teamviewer showed the mon(s) I selected along with Steven's 3 mons, and after the fight concluded the teamviewer returned to showing my whole party. This behaviour was consistent whether I started with a full party or only a few mons like in OP's scenario, and whether I took 1, 2, or 3 mons into the battle

So the bug reported here I couldn't reproduce (at least on vanilla emerald), unsure if it was fixed as part of the code changes in the tracker releases since this post or if the original issue was something weird happening their-end, but the teamviewer is functioning "correctly" currently

I say "correctly" as it is reading the "current" party, the game replaces your party during this fight with the mons you select and Steven's mons shoved into slots 4,5,6 (the teamviewer just ignores any blanks in-between if you select less than 3 mons)

The game does however back up your party into SaveBlock1 before the fight begins (to restore it from afterwards), so it might be possible to make the tracker use that in-place of the "current party" during this fight for the party data the team viewer takes. The downside of this is that it's a snapshot of your party from before the fight so it won't update until after the fight when your party is restored