From 7aefc4469fdef605e084b3a1df7e14f25f68695f Mon Sep 17 00:00:00 2001 From: mk0walsk Date: Tue, 24 Feb 2026 21:58:05 +0800 Subject: [PATCH] refactor: cleanup debug prints and remove unsafe panics --- pkg/ble-driver/bridge_darwin.go | 3 ++- pkg/multipeer-connectivity-driver/driver/cgo_bridge.go | 3 ++- pkg/rendezvous/rendezvous.go | 7 +++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/pkg/ble-driver/bridge_darwin.go b/pkg/ble-driver/bridge_darwin.go index d76b0029..9b4e7950 100644 --- a/pkg/ble-driver/bridge_darwin.go +++ b/pkg/ble-driver/bridge_darwin.go @@ -14,6 +14,7 @@ import "C" import ( "fmt" + "os" "unsafe" "go.uber.org/zap" @@ -97,7 +98,7 @@ func BLEReceiveFromPeer(remotePID *C.char, payload unsafe.Pointer, length C.int) //export BLELog func BLELog(level C.enum_level, message *C.char) { //nolint:revive if gLogger == nil { - fmt.Println("logger not found") + fmt.Fprintf(os.Stderr, "logger not found\n") return } diff --git a/pkg/multipeer-connectivity-driver/driver/cgo_bridge.go b/pkg/multipeer-connectivity-driver/driver/cgo_bridge.go index 9c5887b7..1e969871 100644 --- a/pkg/multipeer-connectivity-driver/driver/cgo_bridge.go +++ b/pkg/multipeer-connectivity-driver/driver/cgo_bridge.go @@ -13,6 +13,7 @@ import "C" import ( "fmt" + "os" "unsafe" "go.uber.org/zap" @@ -71,7 +72,7 @@ func MCReceiveFromPeer(remotePID *C.char, payload unsafe.Pointer, length C.int) //export MCLog func MCLog(level C.enum_level, message *C.char) { //nolint:golint if Logger == nil { - fmt.Println("logger not found") + fmt.Fprintf(os.Stderr, "logger not found\n") return } diff --git a/pkg/rendezvous/rendezvous.go b/pkg/rendezvous/rendezvous.go index da41d91e..80c5682b 100644 --- a/pkg/rendezvous/rendezvous.go +++ b/pkg/rendezvous/rendezvous.go @@ -35,10 +35,9 @@ func GenerateRendezvousPointForPeriod(topic, seed []byte, date time.Time) []byte mac := hmac.New(sha256.New, append(topic, seed...)) binary.BigEndian.PutUint64(buf, uint64(date.Unix())) - _, err := mac.Write(buf) - if err != nil { - panic(err) - } + // hash.Hash.Write never returns an error, as documented at + // https://pkg.go.dev/hash#Hash + mac.Write(buf) //nolint:errcheck sum := mac.Sum(nil) return sum