Unit tests are failing

[arthurgousset]

On the latest commit 13570ed, the unit tests are failing. Is that expected @beholdr ?

I'm looking into #249. I ran all unit tests before submitting my PR, but I noticed the tests are failing on master.

npm run test

> maska@3.1.1 test
> vitest run


 RUN  v3.0.9 /Users/arthur/Documents/hyperdrive-eng/customers/oss/beholdr/maska

 ✓ test/mask.test.ts (54 tests) 9ms
 ❯ test/number.test.ts (13 tests | 4 failed) 36ms
   ✓ default number settings
   ✓ default number unmasked
   × fraction number 5ms
     → expected '1,234,567.11' to be '1,234,567.10' // Object.is equality
   × fraction number unmasked 1ms
     → expected '1234567.11' to be '1234567.10' // Object.is equality
   ✓ unsigned number
   ✓ unsigned false number
   × russian number 1ms
     → expected '1 234 567,11' to be '1 234 567,10' // Object.is equality
   × russian unmasked number 1ms
     → expected '1234567.11' to be '1234567.10' // Object.is equality
   ✓ initial number
   ✓ initial russian number
   ✓ initial brazilian number
   ✓ NaN check
   ✓ float input
stderr | test/input.test.ts > test init > wrong input type
Maska: input of `email` type is not supported

 ✓ test/svelte.test.ts (4 tests) 98ms
 ✓ test/alpine.test.ts (9 tests) 175ms
 ✓ test/vue.test.ts (18 tests) 42ms
 ✓ test/input.test.ts (282 tests) 3609ms

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 4 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/number.test.ts > fraction number
AssertionError: expected '1,234,567.11' to be '1,234,567.10' // Object.is equality

Expected: "1,234,567.10"
Received: "1,234,567.11"

 ❯ test/number.test.ts:55:38
     53|   expect(mask.masked('1234567.1')).toBe('1,234,567.1')
     54|   expect(mask.masked('1234567.10')).toBe('1,234,567.10')
     55|   expect(mask.masked('1234567.109')).toBe('1,234,567.10')
       |                                      ^
     56|   expect(mask.masked('1234567.0')).toBe('1,234,567.0')
     57|   expect(mask.masked('1234567.01')).toBe('1,234,567.01')

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/4]⎯

 FAIL  test/number.test.ts > fraction number unmasked
AssertionError: expected '1234567.11' to be '1234567.10' // Object.is equality

Expected: "1234567.10"
Received: "1234567.11"

 ❯ test/number.test.ts:75:40
     73|   expect(mask.unmasked('1234567.1')).toBe('1234567.1')
     74|   expect(mask.unmasked('1234567.10')).toBe('1234567.10')
     75|   expect(mask.unmasked('1234567.109')).toBe('1234567.10')
       |                                        ^
     76|   expect(mask.unmasked('1234567.0')).toBe('1234567.0')
     77|   expect(mask.unmasked('1234567.01')).toBe('1234567.01')

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/4]⎯

 FAIL  test/number.test.ts > russian number
AssertionError: expected '1 234 567,11' to be '1 234 567,10' // Object.is equality

Expected: "1 234 567,10"
Received: "1 234 567,11"

 ❯ test/number.test.ts:113:38
    111|   expect(mask.masked('1234567.1')).toBe('1 234 567,1')
    112|   expect(mask.masked('1234567.10')).toBe('1 234 567,10')
    113|   expect(mask.masked('1234567.109')).toBe('1 234 567,10')
       |                                      ^
    114|   expect(mask.masked('1234567.0')).toBe('1 234 567,0')
    115|   expect(mask.masked('1234567.01')).toBe('1 234 567,01')

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[3/4]⎯

 FAIL  test/number.test.ts > russian unmasked number
AssertionError: expected '1234567.11' to be '1234567.10' // Object.is equality

Expected: "1234567.10"
Received: "1234567.11"

 ❯ test/number.test.ts:137:40
    135|   expect(mask.unmasked('1234567.1')).toBe('1234567.1')
    136|   expect(mask.unmasked('1234567.10')).toBe('1234567.10')
    137|   expect(mask.unmasked('1234567.109')).toBe('1234567.10')
       |                                        ^
    138|   expect(mask.unmasked('1234567.0')).toBe('1234567.0')
    139|   expect(mask.unmasked('1234567.01')).toBe('1234567.01')

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[4/4]⎯


 Test Files  1 failed | 5 passed (6)
      Tests  4 failed | 376 passed (380)
   Start at  15:03:54
   Duration  4.66s (transform 705ms, setup 2.26s, collect 1.05s, tests 3.97s, environment 1.74s, prepare 404ms)

[beholdr]

@arthurgousset sorry, can’t reproduce. On my machine with node 24.1.0 all tests are passed

[arthurgousset]

Oh curious, I can confirm on node 24.1.0 they pass on my machine too.

npm run test

> maska@3.1.1 test
> vitest run


 RUN  v3.0.9 /Users/arthur/Documents/hyperdrive-eng/customers/oss/beholdr/maska

 ✓ test/mask.test.ts (54 tests) 8ms
 ✓ test/number.test.ts (13 tests) 17ms
stderr | test/input.test.ts > test init > wrong input type
Maska: input of `email` type is not supported

 ✓ test/svelte.test.ts (4 tests) 89ms
 ✓ test/vue.test.ts (18 tests) 38ms
 ✓ test/alpine.test.ts (9 tests) 158ms
 ✓ test/input.test.ts (282 tests) 3853ms

 Test Files  6 passed (6)
      Tests  380 passed (380)
   Start at  15:40:38
   Duration  4.85s (transform 517ms, setup 2.10s, collect 747ms, tests 4.16s, environment 1.56s, prepare 375ms)

For context, they failed with node 18.16.1.

nvm use 18
Now using node v18.16.1 (npm v9.5.1)