Skip to content

Rule no-empty-chunks is not yet useful #45

Description

@forman

Describe the bug

The rule no-empty-chunks ...

  1. outputs a wrong message. Instead of 'write_empty_chunks=True' it should read 'write_empty_chunks=False'.
  2. should not be applied to coordinate variables by default because coordinates are often not chunked.
  3. should be applied to chunked variables only. It seems, it emits also for single chunk variables.
valid.zarr:
dataset.coords['x']               warn  Consider writing the dataset using 'write_empty_chunks=True'.  no-empty-chunks
dataset.coords['y']               warn  Consider writing the dataset using 'write_empty_chunks=True'.  no-empty-chunks
dataset.data_vars['sst']          warn  Consider writing the dataset using 'write_empty_chunks=True'.  no-empty-chunks
dataset.data_vars['sst_anomaly']  warn  Consider writing the dataset using 'write_empty_chunks=True'.  no-empty-chunks
dataset.coords['time']            warn  Missing 'units' attribute in variable 'time'.                  var-units

To Reproduce

Run the notebook notebooks/xrlint-cli.ipynb.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions