Emacs 28.1 no longer uses `ansi-coloir-name-vector` so colours in shells no longer match the theme.

[aardvark179]

I've fixed this in my own theme that I apply on top of zenburn by defining the ansi color faces like this

  (zenburn-with-color-variables
    (custom-theme-set-faces
     'aardvark179-custom
     `(ansi-color-black ((t (t :foreground ,zenburn-bg :background ,zenburn-bg))))
     `(ansi-color-red ((t (:foreground ,zenburn-red :background, zenburn-red))))
     `(ansi-color-green ((t (:foreground ,zenburn-green :background ,zenburn-green))))
     `(ansi-color-yellow ((t (:foreground ,zenburn-yellow :background ,zenburn-yellow))))
     `(ansi-color-blue ((t (:foreground ,zenburn-blue :background ,zenburn-blue))))
     `(ansi-color-magenta ((t (:foreground ,zenburn-magenta :background ,zenburn-magenta))))
     `(ansi-color-cyan ((t (:foreground ,zenburn-cyan :background ,zenburn-cyan))))
     `(ansi-color-white ((t (:foreground ,zenburn-fg :background ,zenburn-fg))))
     ))

But this doesn't cover bright variants, and I'm not sure if darker variants should be used for the background colors.

[impaktor]

I wonder if this is why Zenburn 2024 2.6 has atrocious bad color for ansi-color-freeze-overlay

output from C-u C-x =

             position: 15487 of 23776 (65%), column: 28
            character: _ (displayed as _) (codepoint 95, #o137, #x5f)
              charset: ascii (ASCII (ISO646 IRV))
code point in charset: 0x5F
               script: latin
               syntax: _ 	which means: symbol
             category: .:Base, >:Not at bol, a:ASCII, l:Latin, r:Roman
             to input: type "C-x 8 RET 5f" or "C-x 8 RET LOW LINE"
          buffer code: #x5F
            file code: #x5F (encoded by coding system utf-8-unix)
              display: by this font (glyph code):
    ftcrhb:-ADBO-Source Code Pro-regular-normal-normal-*-13-*-*-*-m-0-iso10646-1 (#x3BD)

Character code properties: customize what to show
  name: LOW LINE
  old-name: SPACING UNDERSCORE
  general-category: Pc (Punctuation, Connector)
  decomposition: (95) ('_')

There is an overlay here:
 From 15478 to 15499
  evaporate            t
  face                 (:background "#F0DFAF")
  insert-behind-hooks  (ansi-color-freeze-overlay)
  modification-hooks   (ansi-color-freeze-overlay)


There are text properties here:
  field                output
  fontified            t
  front-sticky         (field inhibit-line-move-field-capture)
  inhibit-line-move-field-capture t
  insert-in-front-hooks (comint--mark-as-output comint--mark-yanked-as-output)
  rear-nonsticky       (field inhibit-line-move-field-capture read-only font-lock-face insert-in-front-hooks)

[back]