Skip to content

Introduce shared pytest fixtures for manifest/project-root test setup #1912

Description

@codeforester

There is no conftest.py anywhere in the repo. As a result, at least 36 separate test files independently hand-roll base_manifest.yaml construction (e.g. local write_manifest() helpers duplicated across base_trust, base_pr_policy, base_release, and others) instead of sharing one fixture. This is the exact "duplicated helper/API drift" failure mode named in docs/contracts.md's own review taxonomy, just not yet applied to the test suite itself.

Scope:

  • Add conftest.py fixtures (at repo root and/or per-package as appropriate) for common patterns: temp project root, minimal/full base_manifest.yaml construction, common command surfaces.
  • Migrate the most-duplicated call sites to the shared fixtures incrementally; this does not need to be one large PR.

Acceptance criteria:

  • New tests have an obvious shared fixture to reach for instead of re-deriving manifest-writing helpers.
  • The highest-duplication packages (base_trust, base_pr_policy, base_release, base_projects) are migrated.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or product improvement

Type

No type

Projects

Status
Backlog

Relationships

None yet

Development

No branches or pull requests

Issue actions