feat: add 'failed' status for delete operation

Author: abdelhamiderrahmouni

app/Commands/CacheKill.php

@@ -35,6 +35,7 @@ class CacheKill extends Command
      *   'ready'       — size known, awaiting user action
      *   'deleting'    — rm -rf in progress
      *   'deleted'     — rm -rf completed
+     *   'failed'      — rm -rf failed
      *
      * @var array<string, array{label: string, type: string, size: int|null, status: string, lastModified: int|null, order: int}>
      */
@@ -287,6 +288,7 @@ protected function renderBadge(string $status, ?int $size): array
             'ready' => ['  <fg=yellow>' . $this->formatSize($size) . '</>', '  ' . $this->formatSize($size)],
             'deleting' => ['  <fg=yellow;options=bold>deleting...</>', '  deleting...'],
             'deleted' => ['  <fg=green;options=bold>deleted ✓</>', '  deleted ✓'],
+            'failed' => ['  <fg=red;options=bold>delete failed</>', '  delete failed'],
             default => ['', ''],
         };
     }

app/Commands/CnKill.php

@@ -38,6 +38,7 @@ class CnKill extends Command
      *   'ready'       — size known, awaiting user action
      *   'deleting'    — rm -rf in progress
      *   'deleted'     — rm -rf completed
+     *   'failed'      — rm -rf failed
      *
      * @var array<string, array{project: string, size: int|null, status: string, type: string, lastModified: int|null, order: int}>
      */
@@ -115,8 +116,16 @@ class CnKill extends Command
 
     public function handle(): int
     {
-        $searchPath = $this->argument('path') ?? getcwd();
-        $this->searchPath = rtrim((string) realpath($searchPath), DIRECTORY_SEPARATOR);
+        $searchPath = (string) ($this->argument('path') ?? getcwd());
+        $resolvedSearchPath = realpath($searchPath);
+
+        if ($resolvedSearchPath === false || ! is_dir($resolvedSearchPath)) {
+            $this->error('The provided path does not exist or is not a directory: ' . $searchPath);
+
+            return 1;
+        }
+
+        $this->searchPath = $this->normalizePath($resolvedSearchPath);
 
         // Cache options once — avoids repeated option() calls in the hot render loop
         $this->allMode = (bool) $this->option('all');
@@ -292,6 +301,13 @@ protected function startFindProcess(string $searchPath): void
         $this->findProc = ['proc' => $proc, 'pipe' => $pipes[1], 'buf' => ''];
     }
 
+    protected function normalizePath(string $path): string
+    {
+        $trimmed = rtrim($path, DIRECTORY_SEPARATOR);
+
+        return $trimmed === '' ? DIRECTORY_SEPARATOR : $trimmed;
+    }
+
     /**
      * Read whatever is available from find's stdout and register new dirs.
      */
@@ -564,6 +580,7 @@ protected function renderBadge(string $status, ?int $size): array
             'ready' => ['<fg=yellow>' . $this->formatSize($size) . '</>', $this->formatSize($size)],
             'deleting' => ['<fg=yellow;options=bold>deleting...</>', 'deleting...'],
             'deleted' => ['<fg=green;options=bold>deleted ✓</>', 'deleted ✓'],
+            'failed' => ['<fg=red;options=bold>delete failed</>', 'delete failed'],
             default => ['', ''],
         };
     }

app/Commands/Concerns/TuiCommand.php

@@ -202,7 +202,7 @@ protected function startDeleteProcess(string $dir): void
         $proc = proc_open(['rm', '-rf', $dir], $descriptors, $pipes);
 
         if (! is_resource($proc)) {
-            $this->state[$dir]['status'] = 'deleted';
+            $this->state[$dir]['status'] = 'failed';
 
             return;
         }
@@ -226,10 +226,10 @@ protected function pollDeleteProcesses(): void
                 continue;
             }
 
-            proc_close($proc);
+            $exitCode = proc_close($proc);
             unset($this->deleteProcs[$dir]);
 
-            $this->state[$dir]['status'] = 'deleted';
+            $this->state[$dir]['status'] = $exitCode === 0 ? 'deleted' : 'failed';
         }
     }
 
@@ -309,7 +309,7 @@ protected function handleInput(): void
             $dir = $visibleDirs[$this->cursor];
             $status = $this->state[$dir]['status'];
 
-            if ($status === 'ready') {
+            if ($status === 'ready' || $status === 'failed') {
                 $this->state[$dir]['status'] = 'deleting';
                 $this->startDeleteProcess($dir);
             }

tests/Feature/ProcessPathValidationTest.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+it('fails when process path does not exist', function () {
+    $missingPath = '/tmp/cnkill-path-that-does-not-exist';
+
+    $this->artisan('process ' . $missingPath)
+        ->expectsOutput('The provided path does not exist or is not a directory: ' . $missingPath)
+        ->assertExitCode(1);
+});