LSAPy Review N°1

[baptistehamon]

Below are the comments of the first reviewer that need to be addressed before approval. The full package review is here.

Reviewer Comments

Required Changes

1. matplotlib missing from required dependencies — import lsapy fails after a clean pip install lsapy with ModuleNotFoundError: No module named 'matplotlib' (already fixed by Remove deprecated functions module #104)
2. h5py missing from dependencies — test_utils.py::TestOpenData::test_open_land fails with ImportError: No module named 'h5py' (I think Bump virtualenv from 20.33.1 to 20.36.1 in /ci #112 should have fixed it).
3. lsapy.standardize not importable as a submodule — from lsapy.standardize import logistic raises ModuleNotFoundError. Please expose the submodule or update the documentation to use from lsapy import logistic.

Minor Suggestions

• Add a citation/BibTeX section to the README (fixed by Update documentation #151)
• Add a link to development installation instructions on the Installation page (fixed by Update documentation #151).

[baptistehamon]

Hi @tkoyama010, I'm using this issue to track the issues you've indentified. Some of them had been already fixed but were not released. I've fixed/update the code for the other ones. However, I haven't been able to fully reproduce the issues you mention in N°2 and N°3, neither with pip nor conda in a clean environment. I'm pretty sure the N°2 has been already fixed by one of the previous PR, and it might also be the case for the N°3, I'm not sure though. I just release the v0.4.0 of the package. Could you check if these issues are still there in the new release ?