png patch

[plasmoduck]

Hi, can you please add this png patch to allow image previews in dmenu?

https://tools.suckless.org/dmenu/patches/png_images/

[bakkeby]

I suppose I can try. I wonder what the use-case beyond greenclip would be for this.

Have you tried this out in a bare dmenu? It is rather finicky.

[bakkeby]

The patch is rather invasive if one want seamless integration with grid and mousesupport / motionsupport. I am not entirely convinced about taking it.

I pushed a work in progress to a branch png_images for now.

[plasmoduck]

I haven't tried it yet no. I thought it may be good for a dmenu wallpaper script so preview which wallpaper is being selected.

[bakkeby]

Most wallpapers are in .jpg format, so don't think this patch would work well in that context. Probably not too difficult to use imlib instead for loading images though.

nsxiv has a dmenu option for printing out the path to a selected file, but I am not sure how that is intended to be used (like coming from dmenu you might expect enter to print the file and exit rather than toggle between image and thumbnail view, but it didn't behave like that in my limited testing).

[plasmoduck]

All my wallpapers are .png as I prefer the format. Also it's not too hard to change file type anyway. Up to you at the end of the day to include the patch or not. I just thought it might be good idea/welcome edition.

[bakkeby]

You are welcome to try it out if you want. What is on the branch works for the most part. The main thing that doesn't quite work well yet is when you have a grid and have search matches.